Issue 530583004: Rename Error to RequestError in analysis server API.

Issue 530583004: Rename Error to RequestError in analysis server API. (Closed)

Created:
6 years, 3 months ago by Paul Berry

Modified:
6 years, 3 months ago

Reviewers:
jwren, Brian Wilkerson

CC:
reviews_dartlang.org, ricow1

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Rename Error to RequestError in analysis server API. Also, use the code-generated RequestError class in place of the old handwritten RequestError class. R=jwren@google.com Committed: https://code.google.com/p/dart/source/detail?r=39760

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+221 lines, -481 lines)			Patch
D	editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/Error.java	View	1 chunk	+0 lines, -154 lines	0 comments	Download
A +	editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/RequestError.java	View	4 chunks	+11 lines, -11 lines	0 comments	Download
M	pkg/analysis_server/doc/api.html	View	27 chunks	+49 lines, -49 lines	0 comments	Download
M	pkg/analysis_server/lib/src/constants.dart	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	pkg/analysis_server/lib/src/generated_protocol.dart	View	2 chunks	+88 lines, -88 lines	0 comments	Download
M	pkg/analysis_server/lib/src/protocol.dart	View	2 chunks	+2 lines, -111 lines	0 comments	Download
M	pkg/analysis_server/lib/src/socket_server.dart	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	pkg/analysis_server/test/integration/integration_tests.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/analysis_server/test/integration/protocol_matchers.dart	View	2 chunks	+17 lines, -17 lines	0 comments	Download
M	pkg/analysis_server/test/protocol_test.dart	View	2 chunks	+15 lines, -19 lines	0 comments	Download
M	pkg/analysis_server/tool/spec/api.dart	View	1 chunk	+7 lines, -3 lines	0 comments	Download
M	pkg/analysis_server/tool/spec/spec_input.html	View	2 chunks	+27 lines, -27 lines	0 comments	Download

Total messages: 5 (1 generated)

Paul Berry

Jamie: let me know if you want me to delay committing this until you've had ...

6 years, 3 months ago (2014-09-02 17:58:36 UTC) #2

jwren

On 2014/09/02 17:58:36, Paul Berry wrote: > Jamie: let me know if you want me ...

6 years, 3 months ago (2014-09-02 18:10:00 UTC) #3

Paul Berry

Committed patchset #1 manually as 39760 (presubmit successful).

6 years, 3 months ago (2014-09-02 18:20:56 UTC) #4

Message was sent while issue was closed.

LGTM