Rename Error to RequestError in analysis server API.

pkg/analysis_server/test/protocol_test.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library test.protocol;
 
 import 'dart:convert';
 
+import 'package:analysis_server/src/constants.dart';
 import 'package:analysis_server/src/protocol.dart';
 import 'package:analysis_testing/reflective_tests.dart';
 import 'package:unittest/unittest.dart';
 
 
 Matcher _throwsRequestFailure = throwsA(new isInstanceOf<RequestFailure>());
 
 
 main() {
   groupSep = ' | ';
@@ skipping 72 matching lines @@
 }
 
 
 @ReflectiveTestCase()
 class RequestErrorTest {
   void test_create() {
     RequestError error = new RequestError(RequestErrorCode.INVALID_REQUEST, 'msg');
     expect(error.code, RequestErrorCode.INVALID_REQUEST);
     expect(error.message, "msg");
     expect(error.toJson(), equals({
-      RequestError.CODE: 'INVALID_REQUEST',
-      RequestError.MESSAGE: "msg"
+      CODE: 'INVALID_REQUEST',
+      MESSAGE: "msg"
     }));
   }
 
-  void test_create_serverAlreadyStarted() {
-    RequestError error = new RequestError.serverAlreadyStarted();
-    expect(error.code, RequestErrorCode.SERVER_ALREADY_STARTED);
-    expect(error.message, "Server already started");
-  }
-
   void test_fromJson() {
     var json = {
-      RequestError.CODE: RequestErrorCode.INVALID_PARAMETER.name,
-      RequestError.MESSAGE: 'foo',
-      RequestError.DATA: {
+      CODE: RequestErrorCode.INVALID_PARAMETER.name,
+      MESSAGE: 'foo',
+      DATA: {
         'ints': [1, 2, 3]
       }
     };
-    RequestError error = new RequestError.fromJson(json);
+    RequestError error = new RequestError.fromJson(new ResponseDecoder(), '',
+        json);
     expect(error.code, RequestErrorCode.INVALID_PARAMETER);
     expect(error.message, "foo");
     expect(error.data['ints'], [1, 2, 3]);
-    expect(error.getData('ints'), [1, 2, 3]);
   }
 
   void test_toJson() {
-    RequestError error = new RequestError(RequestErrorCode.UNKNOWN_REQUEST, 'msg');
-    error.setData('answer', 42);
-    error.setData('question', 'unknown');
+    RequestError error = new RequestError(
+        RequestErrorCode.UNKNOWN_REQUEST, 'msg', data: {});
+    error.data['answer'] = 42;
+    error.data['question'] = 'unknown';
     expect(error.toJson(), {
-      RequestError.CODE: 'UNKNOWN_REQUEST',
-      RequestError.MESSAGE: 'msg',
-      RequestError.DATA: {
+      CODE: 'UNKNOWN_REQUEST',
+      MESSAGE: 'msg',
+      DATA: {
         'answer': 42,
         'question': 'unknown'
       }
     });
   }
 }
 
 
 @ReflectiveTestCase()
 class RequestTest {
@@ skipping 115 matching lines @@
 
   void test_fromJson_withResult() {
     Response original = new Response('myId', result: {'foo': 'bar'});
     Response response = new Response.fromJson(original.toJson());
     expect(response.id, equals('myId'));
     Map<String, Object> result = response.toJson()['result'];
     expect(result.length, equals(1));
     expect(result['foo'], equals('bar'));
   }
 }