Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 530363003: Put selector generation for the suite_dir runs in the same place as the other selector expansion (Closed)

Created:
6 years, 3 months ago by ricow1
Modified:
6 years, 3 months ago
Reviewers:
Bill Hesse
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Put selector generation for the suite_dir runs in the same place as the other selector expansion R=whesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=39796

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M tools/test.dart View 1 chunk +0 lines, -6 lines 0 comments Download
M tools/testing/dart/test_options.dart View 2 chunks +8 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
ricow1
6 years, 3 months ago (2014-09-03 06:19:52 UTC) #1
Bill Hesse
lgtm
6 years, 3 months ago (2014-09-03 08:00:51 UTC) #2
ricow1
6 years, 3 months ago (2014-09-03 08:12:45 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as r39796 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698