Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Unified Diff: tools/testing/dart/test_options.dart

Issue 530363003: Put selector generation for the suite_dir runs in the same place as the other selector expansion (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/test.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/test_options.dart
===================================================================
--- tools/testing/dart/test_options.dart (revision 39789)
+++ tools/testing/dart/test_options.dart (working copy)
@@ -7,6 +7,7 @@
import "dart:io";
import "drt_updater.dart";
import "test_suite.dart";
+import "utils.dart";
import "compiler_configuration.dart" show CompilerConfiguration;
import "runtime_configuration.dart" show RuntimeConfiguration;
@@ -715,8 +716,13 @@
var selectors = configuration['selectors'];
if (selectors is !Map) {
if (selectors == null) {
- configuration['default_selector'] = true;
- selectors = new List.from(defaultTestSelectors);
+ if (configuration['suite_dir'] != null) {
+ var suite_path = new Path(configuration['suite_dir']);
+ selectors = [suite_path.filename];
+ } else {
+ selectors = new List.from(defaultTestSelectors);
+ }
+
var exclude_suites = configuration['exclude_suite'] != null ?
configuration['exclude_suite'].split(',') : [];
for (var exclude in exclude_suites) {
« no previous file with comments | « tools/test.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698