Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 530123002: Impements 'names', 'offsets' and 'lengths' for ExtractMethodRefactoring. (Closed)

Created:
6 years, 3 months ago by scheglov
Modified:
6 years, 3 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Impements 'names', 'offsets' and 'lengths' for ExtractMethodRefactoring. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=39768

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -2 lines) Patch
M pkg/analysis_server/lib/src/services/refactoring/extract_method.dart View 6 chunks +52 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/services/refactoring/extract_method_test.dart View 1 chunk +38 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
6 years, 3 months ago (2014-09-02 18:16:31 UTC) #1
Brian Wilkerson
LGTM
6 years, 3 months ago (2014-09-02 19:31:37 UTC) #2
scheglov
6 years, 3 months ago (2014-09-02 19:35:52 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 39768 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698