Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Unified Diff: pkg/analysis_server/test/services/refactoring/extract_method_test.dart

Issue 530123002: Impements 'names', 'offsets' and 'lengths' for ExtractMethodRefactoring. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analysis_server/lib/src/services/refactoring/extract_method.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analysis_server/test/services/refactoring/extract_method_test.dart
diff --git a/pkg/analysis_server/test/services/refactoring/extract_method_test.dart b/pkg/analysis_server/test/services/refactoring/extract_method_test.dart
index 54fe381db1ef6674442be0b939694e53060d7414..e039419e8e5dd5f2357470646e670f09945b0994 100644
--- a/pkg/analysis_server/test/services/refactoring/extract_method_test.dart
+++ b/pkg/analysis_server/test/services/refactoring/extract_method_test.dart
@@ -1010,6 +1010,44 @@ class A {
expect(refactoring.refactoringName, 'Extract Method');
}
+ test_names_singleExpression() {
+ indexTestUnit('''
+class TreeItem {}
+TreeItem getSelectedItem() => null;
+process(my) {}
+main() {
+ process(getSelectedItem()); // marker
+ int treeItem = 0;
+}
+''');
+ _createRefactoringWithSuffix('getSelectedItem()', '); // marker');
+ // check names
+ return refactoring.checkInitialConditions().then((_) {
+ expect(
+ refactoring.names,
+ unorderedEquals(['selectedItem', 'item', 'my', 'treeItem2']));
+ });
+ }
+
+ test_offsets_lengths() {
+ indexTestUnit('''
+main() {
+main() {
+ int a = 1 + 2;
+ int b = 1 + 2;
+}
+}
+''');
+ _createRefactoringForString('1 + 2');
+ // apply refactoring
+ return refactoring.checkInitialConditions().then((_) {
+ expect(
+ refactoring.offsets,
+ unorderedEquals([findOffset('1 + 2'), findOffset('1 + 2')]));
+ expect(refactoring.lengths, unorderedEquals([5, 6]));
+ });
+ }
+
test_setExtractGetter() {
indexTestUnit('''
main() {
« no previous file with comments | « pkg/analysis_server/lib/src/services/refactoring/extract_method.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698