Issue 52953002: Hide ClosureMirror.findInContext behind a flag for 1.0.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 52953002: Hide ClosureMirror.findInContext behind a flag for 1.0. (Closed)

Created:
7 years, 1 month ago by rmacnak

Modified:
7 years, 1 month ago

Reviewers:
ahe, gbracha, siva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Hide ClosureMirror.findInContext behind a flag for 1.0. Test findInContext does not wildcard privates. Fix confused test and implementation that expected inheritance of static members. BUG=http://dartbug.com/13656 R=ahe@google.com, asiva@google.com, gbracha@google.com Committed: https://code.google.com/p/dart/source/detail?r=29697

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+133 lines, -176 lines)			Patch
M	runtime/lib/mirrors.cc	View	1	3 chunks	+9 lines, -6 lines	0 comments	Download
M	runtime/lib/mirrors_impl.dart	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	sdk/lib/_internal/lib/js_mirrors.dart	View		1 chunk	+3 lines, -2 lines	0 comments	Download
M	sdk/lib/mirrors/mirrors.dart	View	1	1 chunk	+1 line, -14 lines	0 comments	Download
M	tests/lib/lib.status	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
D	tests/lib/mirrors/closure_mirror_find_in_context_test.dart	View		1 chunk	+0 lines, -151 lines	0 comments	Download
M	tests/lib/mirrors/find_in_context_fake_function_test.dart	View		1 chunk	+2 lines, -0 lines	0 comments	Download
A	tests/lib/mirrors/find_in_context_private_test.dart	View		1 chunk	+104 lines, -0 lines	0 comments	Download
A +	tests/lib/mirrors/find_in_context_test.dart	View		2 chunks	+8 lines, -2 lines	0 comments	Download

Total messages: 5 (0 generated)

rmacnak

7 years, 1 month ago (2013-10-31 20:50:27 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 manually as r29697 (presubmit successful).