runtime/lib/mirrors_impl.dart - Issue 52953002: Hide ClosureMirror.findInContext behind a flag for 1.0.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/lib/mirrors_impl.dart

Issue 52953002: Hide ClosureMirror.findInContext behind a flag for 1.0. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: rebase Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/lib/mirrors_impl.dart

diff --git a/runtime/lib/mirrors_impl.dart b/runtime/lib/mirrors_impl.dart

index 85bbae8387d0bdcee6a7ab820692fef7ebdcf681..adcc8d50ab6a180d0fb62761573ecd61f3ad749e 100644

--- a/runtime/lib/mirrors_impl.dart

+++ b/runtime/lib/mirrors_impl.dart

@@ -469,6 +469,10 @@ class _LocalClosureMirrorImpl extends _LocalInstanceMirrorImpl

throw new ArgumentError("Invalid symbol: ${name}");

}

List tuple = _computeFindInContext(_reflectee, parts);

+ if (tuple.length == 0) {

+ throw new UnsupportedError(

+ "ClosureMirror.findInContext not yet supported");

+ }

if (tuple[0]) {

return reflect(tuple[1]);

}

« no previous file with comments | « runtime/lib/mirrors.cc ('k') | sdk/lib/_internal/lib/js_mirrors.dart » ('j') | no next file with comments »