Issue 528093002: FOUC lint test

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 528093002: FOUC lint test (Closed)

Created:
6 years, 3 months ago by jakemac

Modified:
6 years, 3 months ago

Reviewers:
Siggi Cherem (dart-lang)

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

FOUC lint test BUG= http://dartbug.com/20751 R=sigmund@google.com Committed: https://code.google.com/p/dart/source/detail?r=39872

Patch Set 2 : update changelog/pubspec #

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+99 lines, -5 lines)			Patch
M	pkg/polymer/CHANGELOG.md	View	1	1 chunk	+9 lines, -4 lines	0 comments	Download
M	pkg/polymer/lib/src/build/linter.dart	View	1	1 chunk	+22 lines, -0 lines	0 comments	Download
M	pkg/polymer/pubspec.yaml	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/polymer/test/build/linter_test.dart	View		1 chunk	+67 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Siggi Cherem (dart-lang)

lgtm! https://codereview.chromium.org/528093002/diff/1/pkg/polymer/lib/src/build/linter.dart File pkg/polymer/lib/src/build/linter.dart (right): https://codereview.chromium.org/528093002/diff/1/pkg/polymer/lib/src/build/linter.dart#newcode401 pkg/polymer/lib/src/build/linter.dart:401: while(parent != null && !hasFoucFix) { nit: space ...

6 years, 3 months ago (2014-09-04 00:12:32 UTC) #3

jakemac

6 years, 3 months ago (2014-09-04 14:56:05 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as 39872 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Issue 528093002: FOUC lint test (Closed)

Description

Patch Set 1 #

Patch Set 2 : update changelog/pubspec #

Messages