Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Unified Diff: pkg/polymer/test/build/linter_test.dart

Issue 528093002: FOUC lint test (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: update changelog/pubspec Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/polymer/pubspec.yaml ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/polymer/test/build/linter_test.dart
diff --git a/pkg/polymer/test/build/linter_test.dart b/pkg/polymer/test/build/linter_test.dart
index 4ec76776b0e8942253f877acd08fcb6ab1abeb5f..6e4eedc7933e4e80c1e9bd139d82c9e9b8b3b510 100644
--- a/pkg/polymer/test/build/linter_test.dart
+++ b/pkg/polymer/test/build/linter_test.dart
@@ -625,6 +625,73 @@ void main() {
'warning: custom element "x-a" extends from "li". Did you mean '
'to write <li is="x-a">? (lib/test.html 2 0)'
]);
+
+ const String foucWarning =
+ 'warning: Custom element found in document body without an '
+ '"unresolved" attribute on it or one of its parents. This means '
+ 'your app probably has a flash of unstyled content before it '
+ 'finishes loading. See http://goo.gl/iN03Pj for more info.';
+
+ _testLinter('FOUC warning works', {
+ 'a|lib/a.html': '''
+ <html><body>
+ <link rel="import" href="../../packages/polymer/polymer.html">
+ <polymer-element name="my-element" noscript></polymer-element>
+ <my-element>hello!</my-element>
+ </body></html>
+ ''',
+ 'a|lib/b.html': '''
+ <html><body>
+ <link rel="import" href="../../packages/polymer/polymer.html">
+ <polymer-element name="my-element" noscript></polymer-element>
+ <div><my-element>hello!</my-element></div>
+ </body></html>
+ ''',
+ 'a|lib/c.html': '''
+ <html unresolved><body>
+ <link rel="import" href="../../packages/polymer/polymer.html">
+ <polymer-element name="my-element" noscript></polymer-element>
+ <my-element>hello!</my-element>
+ </body></html>
+ '''
+ }, [
+ '$foucWarning (lib/a.html 3 14)',
+ '$foucWarning (lib/b.html 3 19)',
+ '$foucWarning (lib/c.html 3 14)',
+ ]);
+
+ _testLinter('FOUC, no false positives.', {
+ 'a|lib/a.html': '''
+ <html><body><div unresolved>
+ <link rel="import" href="../../packages/polymer/polymer.html">
+ <polymer-element name="my-element" noscript></polymer-element>
+ <my-element>hello!</my-element>
+ </div></body></html>
+ ''',
+ 'a|lib/b.html': '''
+ <html><body unresolved>
+ <link rel="import" href="../../packages/polymer/polymer.html">
+ <polymer-element name="my-element" noscript></polymer-element>
+ <my-element>hello!</my-element>
+ </body></html>
+ ''',
+ 'a|lib/c.html': '''
+ <html><body>
+ <link rel="import" href="../../packages/polymer/polymer.html">
+ <polymer-element name="my-element" noscript></polymer-element>
+ <polymer-element name="foo-element">
+ <template><my-element>hello!</my-element></template>
+ </polymer-element>
+ </body></html>
+ ''',
+ 'a|lib/d.html': '''
+ <html><body>
+ <link rel="import" href="../../packages/polymer/polymer.html">
+ <polymer-element name="my-element" noscript></polymer-element>
+ <my-element></my-element>
+ </body></html>
+ ''',
+ }, []);
});
group('custom attributes', () {
« no previous file with comments | « pkg/polymer/pubspec.yaml ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698