fix selected index binding to not count microtasks

fix selected index binding to not count microtasks
https://code.google.com/p/dart/issues/detail?id=13968

R=sigmund@google.com

Committed: https://code.google.com/p/dart/source/detail?r=29851

[Jennifer Messerly, 2013-11-04 20:42:53]

note: this is *not* a fix to merge into trunk, just something I had queued up.

[Siggi Cherem (dart-lang), 2013-11-04 20:49:23]

lgtm

https://codereview.chromium.org/52553007/diff/1/pkg/template_binding/lib/src/...
File pkg/template_binding/lib/src/input_bindings.dart (left):

https://codereview.chromium.org/52553007/diff/1/pkg/template_binding/lib/src/...
pkg/template_binding/lib/src/input_bindings.dart:159: var maxRetries = 4;
yay!

https://codereview.chromium.org/52553007/diff/1/pkg/template_binding/test/tem...
File pkg/template_binding/test/template_binding_test.dart (right):

https://codereview.chromium.org/52553007/diff/1/pkg/template_binding/test/tem...
pkg/template_binding/test/template_binding_test.dart:1173: return new
Future.delayed(Duration.ZERO, () {
I believe this is equivalent to do: new Future(() { })

[Jennifer Messerly, 2013-11-04 21:58:38]

https://codereview.chromium.org/52553007/diff/1/pkg/template_binding/test/tem...
File pkg/template_binding/test/template_binding_test.dart (right):

https://codereview.chromium.org/52553007/diff/1/pkg/template_binding/test/tem...
pkg/template_binding/test/template_binding_test.dart:1173: return new
Future.delayed(Duration.ZERO, () {
On 2013/11/04 20:49:23, Siggi Cherem (dart-lang) wrote:
> I believe this is equivalent to do: new Future(() { })

dug into the code, it doesn't look like it. new Future.delayed() is based on a
Timer, new Future() will do a scheduleMicrotask. That would happen too soon for
this test.

[Siggi Cherem (dart-lang), 2013-11-04 22:09:22]

On 2013/11/04 21:58:38, John Messerly wrote:
>
https://codereview.chromium.org/52553007/diff/1/pkg/template_binding/test/tem...
> File pkg/template_binding/test/template_binding_test.dart (right):
> 
>
https://codereview.chromium.org/52553007/diff/1/pkg/template_binding/test/tem...
> pkg/template_binding/test/template_binding_test.dart:1173: return new
> Future.delayed(Duration.ZERO, () {
> On 2013/11/04 20:49:23, Siggi Cherem (dart-lang) wrote:
> > I believe this is equivalent to do: new Future(() { })
> 
> dug into the code, it doesn't look like it. new Future.delayed() is based on a
> Timer, new Future() will do a scheduleMicrotask. That would happen too soon
for
> this test.

It happens that now Future.microtask does, but 'new Future(closure)` internally
calls Timer.run, which now runs with a ZERO delay (it used to run with runAsync,
so that's why it's so confusing).

[Jennifer Messerly, 2013-11-04 22:10:40]

awesome! fixed

[Jennifer Messerly, 2013-11-04 22:10:53]

Committed patchset #2 manually as r29851 (presubmit successful).