fix selected index binding to not count microtasks

pkg/template_binding/lib/src/input_bindings.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of template_binding;
 
 abstract class _InputBinding extends NodeBinding {
   StreamSubscription _eventSub;
 
   _InputBinding(node, name, model, path): super(node, name, model, path) {
@@ skipping 110 matching lines @@
       if (treeScope == null) return const [];
 
       var radios = treeScope.querySelectorAll(
           'input[type="radio"][name="${element.name}"]');
       return radios.where((el) => el != element && el.form == null);
     }
   }
 }
 
 class _SelectBinding extends _InputBinding {
+  MutationObserver _onMutation;
+
   _SelectBinding(node, property, model, path)
       : super(node, property, model, path);
 
   SelectElement get node => super.node;
 
   void valueChanged(newValue) {
+    _cancelMutationObserver();
+
     if (_tryUpdateValue(newValue)) return;
 
-    // The binding may wish to bind to an <option> which has not yet been
-    // produced by a child <template>. Furthermore, we may need to wait for
-    // <optgroup> iterating and then for <option>.
-    //
-    // Unlike the JavaScript implemenation, we don't have a special
-    // "Object.observe" event loop to schedule on.
-    // (See the the "ensureScheduled" function:
-    // https://github.com/Polymer/mdv/commit/9a51ad7ed74a292bf71662cea28acbd151ff65c8)
-    //
-    // Instead we use scheduleMicrotask. Each <template repeat> needs a delay of
-    // 2:
-    //   * once to happen after the child _TemplateIterator is created
-    //   * once to be after _TemplateIterator's CompoundPathObserver resolve
-    // And then we need to do this delay sequence twice:
-    //   * once for OPTGROUP
-    //   * once for OPTION.
-    // The resulting 2 * 2 is our maxRetries.
-    //
-    // TODO(jmesserly): a much better approach would be to find the nested
-    // <template> and wait on some future that completes when it has expanded.
-    var maxRetries = 4;

[Siggi Cherem (dart-lang), 2013/11/04 20:49:23]

yay! 

-    delaySetSelectedIndex() {
-      if (!_tryUpdateValue(newValue) && maxRetries-- > 0) {
-        scheduleMicrotask(delaySetSelectedIndex);
-      }
-    }
+    // It could be that a template will expand an <option> child (or grandchild,
+    // if we have an <optgroup> in between). Since selected index cannot be set
+    // if the children aren't created yet, we need to wait for them to be
+    // created do this with a MutationObserver.
+    // Dart note: unlike JS we use mutation observers to avoid:
+    // https://github.com/Polymer/NodeBind/issues/5
 
-    scheduleMicrotask(delaySetSelectedIndex);
+    // Note: it doesn't matter when the children get added; even if they get
+    // added much later, presumably we want the selected index data binding to
+    // still take effect.
+    _onMutation = new MutationObserver((x, y) {
+      if (_tryUpdateValue(value)) _cancelMutationObserver();
+    })..observe(node, childList: true, subtree: true);
   }
 
   bool _tryUpdateValue(newValue) {
     if (property == 'selectedIndex') {
       var intValue = _toInt(newValue);
       node.selectedIndex = intValue;
       return node.selectedIndex == intValue;
     } else if (property == 'value') {
       node.value = sanitizeBoundValue(newValue);
       return node.value == newValue;
     }
   }
 
+  void _cancelMutationObserver() {
+    if (_onMutation != null) {
+      _onMutation.disconnect();
+      _onMutation = null;
+    }
+  }
+
   void nodeValueChanged(e) {
+    _cancelMutationObserver();
+
     if (property == 'selectedIndex') {
       value = node.selectedIndex;
     } else if (property == 'value') {
       value = node.value;
     }
   }
 
   // TODO(jmesserly,sigmund): I wonder how many bindings typically convert from
   // one type to another (e.g. value-as-number) and whether it is useful to
   // have something like a int/num binding converter (either as a base class or
   // a wrapper).
   static int _toInt(value) {
     if (value is String) return int.parse(value, onError: (_) => 0);
     return value is int ? value : 0;
   }
 }