Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 524433002: Reapply "Give instances their own model class; move DartErrors out of instance-ref into their own e… (Closed)

Created:
6 years, 3 months ago by rmacnak
Modified:
6 years, 3 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, turnidge, Cutch, vm-dev_dartlang.org
Visibility:
Public.

Description

Reapply "Give instances their own model class; move DartErrors out of instance-ref into their own error-ref." Update inbound_references_test R=johnmccutchan@google.com Committed: https://code.google.com/p/dart/source/detail?r=39758

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+962 lines, -378 lines) Patch
M runtime/bin/vmservice/observatory/deployed/web/index.html View 19 chunks +341 lines, -76 lines 0 comments Download
M runtime/bin/vmservice/observatory/deployed/web/index.html._data View 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/vmservice/observatory/deployed/web/index_devtools.html View 19 chunks +341 lines, -76 lines 0 comments Download
M runtime/bin/vmservice/observatory/deployed/web/index_devtools.html._data View 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/vmservice/observatory/deployed/web/packages/observatory/src/elements/class_view.html View 3 chunks +3 lines, -4 lines 0 comments Download
M runtime/bin/vmservice/observatory/deployed/web/packages/observatory/src/elements/code_view.html View 1 chunk +1 line, -1 line 0 comments Download
A runtime/bin/vmservice/observatory/deployed/web/packages/observatory/src/elements/error_ref.html View 1 chunk +26 lines, -0 lines 0 comments Download
M runtime/bin/vmservice/observatory/deployed/web/packages/observatory/src/elements/eval_box.html View 2 chunks +2 lines, -1 line 0 comments Download
M runtime/bin/vmservice/observatory/deployed/web/packages/observatory/src/elements/eval_link.html View 2 chunks +2 lines, -1 line 0 comments Download
M runtime/bin/vmservice/observatory/deployed/web/packages/observatory/src/elements/field_view.html View 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/vmservice/observatory/deployed/web/packages/observatory/src/elements/instance_ref.html View 2 chunks +16 lines, -30 lines 0 comments Download
M runtime/bin/vmservice/observatory/deployed/web/packages/observatory/src/elements/instance_view.html View 6 chunks +31 lines, -32 lines 0 comments Download
M runtime/bin/vmservice/observatory/deployed/web/packages/observatory/src/elements/library_view.html View 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/vmservice/observatory/deployed/web/packages/observatory/src/elements/stack_frame.html View 1 chunk +1 line, -1 line 0 comments Download
A + runtime/bin/vmservice/observatory/deployed/web/packages/unittest/coverage_controller.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + runtime/bin/vmservice/observatory/deployed/web/packages/unittest/test_controller.js View 0 chunks +-1 lines, --1 lines 0 comments Download
runtime/bin/vmservice/observatory/lib/src/elements/class_view.html View 3 chunks +3 lines, -4 lines 0 comments Download
M runtime/bin/vmservice/observatory/lib/src/elements/code_view.html View 1 chunk +1 line, -1 line 0 comments Download
A runtime/bin/vmservice/observatory/lib/src/elements/error_ref.dart View 1 chunk +14 lines, -0 lines 0 comments Download
A runtime/bin/vmservice/observatory/lib/src/elements/error_ref.html View 1 chunk +26 lines, -0 lines 0 comments Download
M runtime/bin/vmservice/observatory/lib/src/elements/error_view.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/vmservice/observatory/lib/src/elements/eval_box.html View 2 chunks +2 lines, -1 line 0 comments Download
M runtime/bin/vmservice/observatory/lib/src/elements/eval_link.html View 2 chunks +2 lines, -1 line 0 comments Download
M runtime/bin/vmservice/observatory/lib/src/elements/field_view.html View 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/vmservice/observatory/lib/src/elements/inbound_reference.dart View 2 chunks +2 lines, -3 lines 0 comments Download
M runtime/bin/vmservice/observatory/lib/src/elements/instance_ref.dart View 1 chunk +7 lines, -7 lines 0 comments Download
M runtime/bin/vmservice/observatory/lib/src/elements/instance_ref.html View 2 chunks +16 lines, -30 lines 0 comments Download
M runtime/bin/vmservice/observatory/lib/src/elements/instance_view.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/vmservice/observatory/lib/src/elements/instance_view.html View 6 chunks +31 lines, -32 lines 0 comments Download
M runtime/bin/vmservice/observatory/lib/src/elements/library_view.html View 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/vmservice/observatory/lib/src/elements/observatory_element.dart View 1 chunk +0 lines, -60 lines 0 comments Download
M runtime/bin/vmservice/observatory/lib/src/elements/service_ref.dart View 3 chunks +6 lines, -1 line 0 comments Download
M runtime/bin/vmservice/observatory/lib/src/elements/stack_frame.html View 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/vmservice/observatory/lib/src/service/object.dart View 5 chunks +75 lines, -3 lines 0 comments Download
M runtime/bin/vmservice/observatory/test/inbound_references_test.dart View 2 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
rmacnak
rmacnak@google.com changed reviewers: + johnmccutchan@google.com
6 years, 3 months ago (2014-08-28 23:47:36 UTC) #1
rmacnak
6 years, 3 months ago (2014-08-28 23:47:36 UTC) #2
rmacnak
synced; deals with the change to vmType
6 years, 3 months ago (2014-09-02 17:43:45 UTC) #3
Cutch
lgtm
6 years, 3 months ago (2014-09-02 17:45:12 UTC) #4
rmacnak
6 years, 3 months ago (2014-09-02 17:47:34 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:10001) manually as 39758 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698