Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(545)

Unified Diff: runtime/bin/vmservice/observatory/test/inbound_references_test.dart

Issue 524433002: Reapply "Give instances their own model class; move DartErrors out of instance-ref into their own e… (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/bin/vmservice/observatory/lib/src/service/object.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/bin/vmservice/observatory/test/inbound_references_test.dart
diff --git a/runtime/bin/vmservice/observatory/test/inbound_references_test.dart b/runtime/bin/vmservice/observatory/test/inbound_references_test.dart
index b276f1a5f5fd84abe2981ad851ccd72be3307dc4..f515671caa55a1542909795280b21d9896886970 100644
--- a/runtime/bin/vmservice/observatory/test/inbound_references_test.dart
+++ b/runtime/bin/vmservice/observatory/test/inbound_references_test.dart
@@ -30,8 +30,8 @@ var tests = [
(Isolate isolate) =>
isolate.rootLib.load().then((Library lib) {
- ServiceMap e = lib.variables.where((v) => v.name == 'e').single['value'];
- var id = e['id'];
+ Instance e = lib.variables.where((v) => v.name == 'e').single['value'];
+ var id = e.id;
return isolate.get('/$id/inbound_references?limit=100').then(
(ServiceMap response) {
List references = response['references'];
@@ -44,10 +44,10 @@ var tests = [
hasReferenceSuchThat((r) => r['slot'] is Map &&
r['slot']['type']=='@Field' &&
r['slot']['name']=='edge' &&
- r['source']['type']=='@Instance' &&
- r['source']['class'].name=='Node');
- hasReferenceSuchThat((r) => r['slot']==1 &&
- r['source']['type']=='@Array');
+ r['source'].isInstance &&
+ r['source'].clazz.name=='Node');
+ hasReferenceSuchThat((r) => r['slot'] == 1 &&
+ r['source'].isList);
hasReferenceSuchThat((r) => r['slot']=='<unknown>' &&
r['source']['type']=='@Field');
});
« no previous file with comments | « runtime/bin/vmservice/observatory/lib/src/service/object.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698