Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 52293002: In checked mode, parameters are already explicitly checked in the inferrer graph. So there is no ne… (Closed)

Created:
7 years, 1 month ago by ngeoffray
Modified:
7 years, 1 month ago
Reviewers:
kasperl
CC:
reviews_dartlang.org
Visibility:
Public.

Description

In checked mode, parameters are already explicitly checked in the inferrer graph. So there is no need to narrow them. R=kasperl@google.com Committed: https://code.google.com/p/dart/source/detail?r=29542

Patch Set 1 : #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -19 lines) Patch
M pkg/pkg.status View 1 1 chunk +0 lines, -1 line 0 comments Download
M sdk/lib/_internal/compiler/implementation/inferrer/type_graph_inferrer.dart View 1 1 chunk +0 lines, -18 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/inferrer/type_graph_nodes.dart View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
ngeoffray
Without this change, the SSA graph goes into a bogus state where a parameter with ...
7 years, 1 month ago (2013-10-30 10:20:18 UTC) #1
kasperl
LGTM. Do you need to update the status file?
7 years, 1 month ago (2013-10-30 13:14:59 UTC) #2
ngeoffray
On 2013/10/30 13:14:59, kasperl wrote: > LGTM. Do you need to update the status file? ...
7 years, 1 month ago (2013-10-30 13:18:47 UTC) #3
ngeoffray
7 years, 1 month ago (2013-10-30 13:19:13 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r29542 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698