Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Unified Diff: sdk/lib/_internal/compiler/implementation/inferrer/type_graph_inferrer.dart

Issue 52293002: In checked mode, parameters are already explicitly checked in the inferrer graph. So there is no ne… (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/pkg.status ('k') | sdk/lib/_internal/compiler/implementation/inferrer/type_graph_nodes.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/_internal/compiler/implementation/inferrer/type_graph_inferrer.dart
===================================================================
--- sdk/lib/_internal/compiler/implementation/inferrer/type_graph_inferrer.dart (revision 29532)
+++ sdk/lib/_internal/compiler/implementation/inferrer/type_graph_inferrer.dart (working copy)
@@ -493,24 +493,6 @@
compiler.log('Inferred $overallRefineCount types.');
- if (compiler.enableTypeAssertions) {
- // Undo the narrowing of parameters types. Parameters are being
- // checked by the method, and we can therefore only trust their
- // type after the checks. It is okay for the inferrer to rely on
- // the type annotations, but the backend should has to
- // insert the checks.
- types.typeInformations.forEach((Element element,
- ElementTypeInformation info) {
- if (element.isParameter() || element.isFieldParameter()) {
- if (info.abandonInferencing) {
- info.type = types.dynamicType.type;
- } else {
- info.type = types.computeTypeMask(info.assignments);
- }
- }
- });
- }
-
processLoopInformation();
}
« no previous file with comments | « pkg/pkg.status ('k') | sdk/lib/_internal/compiler/implementation/inferrer/type_graph_nodes.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698