Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 517043002: Re-implementation of the analysis.outline in the java layer, this uses the generated types, and rem… (Closed)

Created:
6 years, 3 months ago by jwren
Modified:
6 years, 3 months ago
CC:
reviews_dartlang.org, ricow1
Visibility:
Public.

Description

Re-implementation of the analysis.outline in the java layer, this uses the generated types, and removes the hand written versions R=scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=39672

Patch Set 1 #

Patch Set 2 : rebase with bleeding_edge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -289 lines) Patch
M editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/AnalysisServerListener.java View 1 chunk +1 line, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/AnalysisServerListenerAdapter.java View 1 chunk +1 line, -0 lines 0 comments Download
D editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/Outline.java View 1 chunk +0 lines, -72 lines 0 comments Download
M editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/Outline.java View 2 chunks +26 lines, -22 lines 0 comments Download
M editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/internal/BroadcastAnalysisServerListener.java View 2 chunks +1 line, -1 line 0 comments Download
D editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/internal/OutlineImpl.java View 1 chunk +0 lines, -113 lines 0 comments Download
M editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/internal/remote/processor/NotificationAnalysisOutlineProcessor.java View 2 chunks +2 lines, -36 lines 0 comments Download
M editor/tools/plugins/com.google.dart.server_test/src/com/google/dart/server/internal/TestAnalysisServerListener.java View 2 chunks +1 line, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.server_test/src/com/google/dart/server/internal/remote/RemoteAnalysisServerImplTest.java View 4 chunks +6 lines, -6 lines 0 comments Download
M editor/tools/plugins/com.google.dart.server_test/src/com/google/dart/server/timing/AnalyzeEngineInServer.java View 2 chunks +1 line, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/analysis/model/AnalysisServerData.java View 1 chunk +1 line, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/analysis/model/AnalysisServerOutlineListener.java View 1 chunk +1 line, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/analysis/model/AnalysisServerDataImpl.java View 1 chunk +1 line, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/analysis/model/WorkspaceAnalysisServerListener.java View 2 chunks +1 line, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/editor/DartEditor.java View 1 chunk +1 line, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/editor/DartOutlinePage_NEW.java View 3 chunks +7 lines, -3 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/editor/LightNodeElements.java View 2 chunks +2 lines, -2 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/functions/DartOutlineInformationControl_NEW.java View 4 chunks +6 lines, -4 lines 0 comments Download
M pkg/analysis_server/tool/spec/codegen_java_types.dart View 1 chunk +28 lines, -23 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
jwren
jwren@google.com changed reviewers: + brianwilkerson@google.com, paulberry@google.com, scheglov@google.com
6 years, 3 months ago (2014-08-28 19:41:40 UTC) #1
jwren
6 years, 3 months ago (2014-08-28 19:41:40 UTC) #2
scheglov
LGTM
6 years, 3 months ago (2014-08-28 19:50:23 UTC) #3
jwren
Committed patchset #2 (id:20001) manually as 39672 (presubmit successful).
6 years, 3 months ago (2014-08-28 19:52:45 UTC) #4
Brian Wilkerson
6 years, 3 months ago (2014-08-29 04:40:19 UTC) #5
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698