Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2710)

Unified Diff: editor/tools/plugins/com.google.dart.server_test/src/com/google/dart/server/internal/remote/RemoteAnalysisServerImplTest.java

Issue 517043002: Re-implementation of the analysis.outline in the java layer, this uses the generated types, and rem… (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: rebase with bleeding_edge Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: editor/tools/plugins/com.google.dart.server_test/src/com/google/dart/server/internal/remote/RemoteAnalysisServerImplTest.java
diff --git a/editor/tools/plugins/com.google.dart.server_test/src/com/google/dart/server/internal/remote/RemoteAnalysisServerImplTest.java b/editor/tools/plugins/com.google.dart.server_test/src/com/google/dart/server/internal/remote/RemoteAnalysisServerImplTest.java
index 39a4e1037577bb83377896794eb61a1c522535a9..08d1856b3b8975b74bf1dfaf41a2f513bac302e9 100644
--- a/editor/tools/plugins/com.google.dart.server_test/src/com/google/dart/server/internal/remote/RemoteAnalysisServerImplTest.java
+++ b/editor/tools/plugins/com.google.dart.server_test/src/com/google/dart/server/internal/remote/RemoteAnalysisServerImplTest.java
@@ -21,7 +21,6 @@ import com.google.dart.server.GetHoverConsumer;
import com.google.dart.server.GetSuggestionsConsumer;
import com.google.dart.server.GetTypeHierarchyConsumer;
import com.google.dart.server.GetVersionConsumer;
-import com.google.dart.server.Outline;
import com.google.dart.server.SearchIdConsumer;
import com.google.dart.server.SearchResult;
import com.google.dart.server.SearchResultKind;
@@ -44,6 +43,7 @@ import com.google.dart.server.generated.types.HoverInformation;
import com.google.dart.server.generated.types.Location;
import com.google.dart.server.generated.types.NavigationRegion;
import com.google.dart.server.generated.types.Occurrences;
+import com.google.dart.server.generated.types.Outline;
import com.google.dart.server.generated.types.OverriddenMember;
import com.google.dart.server.generated.types.OverrideMember;
import com.google.dart.server.generated.types.RemoveContentOverlay;
@@ -502,8 +502,8 @@ public class RemoteAnalysisServerImplTest extends AbstractRemoteServerTest {
// assertions on outline
assertThat(outline.getChildren()).hasSize(1);
- assertEquals(1, outline.getOffset());
- assertEquals(2, outline.getLength());
+ assertEquals(new Integer(1), outline.getOffset());
+ assertEquals(new Integer(2), outline.getLength());
Element element = outline.getElement();
assertEquals(ElementKind.COMPILATION_UNIT, element.getKind());
assertEquals("name0", element.getName());
@@ -523,9 +523,9 @@ public class RemoteAnalysisServerImplTest extends AbstractRemoteServerTest {
assertEquals("returnType0", element.getReturnType());
// assertions on child
- Outline child = outline.getChildren()[0];
- assertEquals(7, child.getOffset());
- assertEquals(8, child.getLength());
+ Outline child = outline.getChildren().get(0);
+ assertEquals(new Integer(7), child.getOffset());
+ assertEquals(new Integer(8), child.getLength());
assertThat(child.getChildren()).hasSize(0);
Element childElement = child.getElement();
assertEquals(ElementKind.CLASS, childElement.getKind());

Powered by Google App Engine
This is Rietveld 408576698