Issue 511413002: Revert "Give instances their own model class; move DartErrors out of instance-ref into their own er…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 511413002: Revert "Give instances their own model class; move DartErrors out of instance-ref into their own er… (Closed)

Created:
6 years, 3 months ago by rmacnak

Modified:
6 years, 3 months ago

Reviewers:

CC:
reviews_dartlang.org, turnidge, Cutch, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Revert "Give instances their own model class; move DartErrors out of instance-ref into their own error-ref." Committed: https://code.google.com/p/dart/source/detail?r=39686

Patch Set 1 #

Created: 6 years, 3 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+3231 lines, -4268 lines)			Patch
M	runtime/bin/vmservice/observatory/deployed/web/index.html	View	19 chunks	+76 lines, -341 lines	0 comments	Download
M	runtime/bin/vmservice/observatory/deployed/web/index.html._data	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/bin/vmservice/observatory/deployed/web/index.html_bootstrap.dart.js	View	488 chunks	+1403 lines, -1494 lines	0 comments	Download
M	runtime/bin/vmservice/observatory/deployed/web/index_devtools.html	View	19 chunks	+76 lines, -341 lines	0 comments	Download
M	runtime/bin/vmservice/observatory/deployed/web/index_devtools.html._data	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/bin/vmservice/observatory/deployed/web/index_devtools.html_bootstrap.dart.js	View	488 chunks	+1403 lines, -1494 lines	0 comments	Download
M	runtime/bin/vmservice/observatory/deployed/web/packages/observatory/src/elements/class_view.html	View	3 chunks	+4 lines, -3 lines	0 comments	Download
M	runtime/bin/vmservice/observatory/deployed/web/packages/observatory/src/elements/code_view.html	View	1 chunk	+1 line, -1 line	0 comments	Download
D	runtime/bin/vmservice/observatory/deployed/web/packages/observatory/src/elements/error_ref.html	View	1 chunk	+0 lines, -26 lines	0 comments	Download
M	runtime/bin/vmservice/observatory/deployed/web/packages/observatory/src/elements/eval_box.html	View	2 chunks	+1 line, -2 lines	0 comments	Download
M	runtime/bin/vmservice/observatory/deployed/web/packages/observatory/src/elements/eval_link.html	View	2 chunks	+1 line, -2 lines	0 comments	Download
M	runtime/bin/vmservice/observatory/deployed/web/packages/observatory/src/elements/field_view.html	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/bin/vmservice/observatory/deployed/web/packages/observatory/src/elements/instance_ref.html	View	2 chunks	+30 lines, -16 lines	0 comments	Download
M	runtime/bin/vmservice/observatory/deployed/web/packages/observatory/src/elements/instance_view.html	View	6 chunks	+32 lines, -31 lines	0 comments	Download
M	runtime/bin/vmservice/observatory/deployed/web/packages/observatory/src/elements/library_view.html	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/bin/vmservice/observatory/deployed/web/packages/observatory/src/elements/stack_frame.html	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/bin/vmservice/observatory/deployed/web/packages/polymer/boot.js	View	1 chunk	+6 lines, -1 line	0 comments	Download
M	runtime/bin/vmservice/observatory/deployed/web/packages/polymer/src/js/polymer/build.log	View	1 chunk	+13 lines, -16 lines	0 comments	Download
M	runtime/bin/vmservice/observatory/deployed/web/packages/polymer/src/js/polymer/polymer.js	View	1 chunk	+4 lines, -4 lines	0 comments	Download
D	runtime/bin/vmservice/observatory/deployed/web/packages/unittest/coverage_controller.js	View	1 chunk	+0 lines, -31 lines	0 comments	Download
D	runtime/bin/vmservice/observatory/deployed/web/packages/unittest/test_controller.js	View	1 chunk	+0 lines, -233 lines	0 comments	Download
M	runtime/bin/vmservice/observatory/deployed/web/packages/web_components/build.log	View	1 chunk	+22 lines, -31 lines	0 comments	Download
M	runtime/bin/vmservice/observatory/deployed/web/packages/web_components/platform.js	View	1 chunk	+6 lines, -6 lines	0 comments	Download
M	runtime/bin/vmservice/observatory/lib/src/elements/class_view.html	View	3 chunks	+4 lines, -3 lines	0 comments	Download
M	runtime/bin/vmservice/observatory/lib/src/elements/code_view.html	View	1 chunk	+1 line, -1 line	0 comments	Download
D	runtime/bin/vmservice/observatory/lib/src/elements/error_ref.dart	View	1 chunk	+0 lines, -14 lines	0 comments	Download
D	runtime/bin/vmservice/observatory/lib/src/elements/error_ref.html	View	1 chunk	+0 lines, -26 lines	0 comments	Download
M	runtime/bin/vmservice/observatory/lib/src/elements/error_view.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/bin/vmservice/observatory/lib/src/elements/eval_box.html	View	2 chunks	+1 line, -2 lines	0 comments	Download
M	runtime/bin/vmservice/observatory/lib/src/elements/eval_link.html	View	2 chunks	+1 line, -2 lines	0 comments	Download
M	runtime/bin/vmservice/observatory/lib/src/elements/field_view.html	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/bin/vmservice/observatory/lib/src/elements/inbound_reference.dart	View	2 chunks	+3 lines, -2 lines	0 comments	Download
M	runtime/bin/vmservice/observatory/lib/src/elements/instance_ref.dart	View	1 chunk	+7 lines, -7 lines	0 comments	Download
M	runtime/bin/vmservice/observatory/lib/src/elements/instance_ref.html	View	2 chunks	+30 lines, -16 lines	0 comments	Download
M	runtime/bin/vmservice/observatory/lib/src/elements/instance_view.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/bin/vmservice/observatory/lib/src/elements/instance_view.html	View	6 chunks	+32 lines, -31 lines	0 comments	Download
M	runtime/bin/vmservice/observatory/lib/src/elements/library_view.html	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/bin/vmservice/observatory/lib/src/elements/observatory_element.dart	View	1 chunk	+60 lines, -0 lines	0 comments	Download
M	runtime/bin/vmservice/observatory/lib/src/elements/service_ref.dart	View	3 chunks	+1 line, -6 lines	0 comments	Download
M	runtime/bin/vmservice/observatory/lib/src/elements/stack_frame.html	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/bin/vmservice/observatory/lib/src/service/object.dart	View	5 chunks	+3 lines, -75 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

rmacnak

6 years, 3 months ago (2014-08-28 23:05:33 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 39686 (presubmit successful).

Expand Messages | Collapse Messages