Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1570)

Unified Diff: runtime/bin/vmservice/observatory/lib/src/elements/class_view.html

Issue 511413002: Revert "Give instances their own model class; move DartErrors out of instance-ref into their own er… (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/bin/vmservice/observatory/lib/src/elements/class_view.html
diff --git a/runtime/bin/vmservice/observatory/lib/src/elements/class_view.html b/runtime/bin/vmservice/observatory/lib/src/elements/class_view.html
index 5b0386780c0a9adbd4b3d1d899b94551202fe880..de1e0a458e1a9e0906956bf44d1f81c3b40dcec4 100644
--- a/runtime/bin/vmservice/observatory/lib/src/elements/class_view.html
+++ b/runtime/bin/vmservice/observatory/lib/src/elements/class_view.html
@@ -92,7 +92,8 @@
</div>
<template if="{{ cls.error != null }}">
- <error-ref ref="{{ cls.error }}"></error>
+ <!-- TODO(turnidge): Don't use instance-ref for error display here -->
+ <instance-ref ref="{{ cls.error }}"></instance-ref>
</template>
<hr>
@@ -109,7 +110,7 @@
</div>
<div class="memberValue">
<template if="{{ field['value'] != null }}">
- <any-service-ref ref="{{ field['value'] }}"></any-service-ref>
+ <instance-ref ref="{{ field['value'] }}"></instance-ref>
</template>
</div>
</div>
@@ -154,7 +155,7 @@
</template>
<template if="{{ instances != null }}">
sample
- <any-service-ref ref="{{ instances['sample'] }}"></any-service-ref>
+ <instance-ref ref="{{ instances['sample'] }}"></instance-ref>
<template if="{{ instances['totalCount'] > instances['sampleCount'] }}">
<eval-link callback="{{ reachable }}"
label="[more]"

Powered by Google App Engine
This is Rietveld 408576698