Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 507653004: update polymer to 0.3.5 (Closed)

Created:
6 years, 3 months ago by jakemac
Modified:
6 years, 3 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

add content tag to the js_interop_test element so its content is queryable update web_components to latest BUG= http://dartbug.com/20413 R=sigmund@google.com Committed: https://code.google.com/p/dart/source/detail?r=39596

Patch Set 1 #

Patch Set 2 : update changelog for web_components #

Patch Set 3 : updating pubspecs and changelogs to reflect breaking change with bug in web_components #

Total comments: 8

Patch Set 4 : code review updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1959 lines, -1331 lines) Patch
M pkg/pkg.status View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M pkg/polymer/CHANGELOG.md View 1 2 3 1 chunk +6 lines, -0 lines 0 comments Download
M pkg/polymer/lib/src/declaration.dart View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/polymer/lib/src/events.dart View 1 2 3 2 chunks +14 lines, -9 lines 0 comments Download
M pkg/polymer/lib/src/instance.dart View 1 2 3 5 chunks +6 lines, -12 lines 0 comments Download
M pkg/polymer/lib/src/js/polymer/build.log View 1 2 3 1 chunk +13 lines, -16 lines 0 comments Download
M pkg/polymer/lib/src/js/polymer/polymer.js View 1 2 3 1 chunk +4 lines, -4 lines 0 comments Download
M pkg/polymer/lib/src/js/polymer/polymer.concat.js View 1 2 3 57 chunks +359 lines, -328 lines 0 comments Download
M pkg/polymer/lib/src/js/polymer/polymer.concat.js.map View 1 2 3 3 chunks +27 lines, -27 lines 0 comments Download
M pkg/polymer/lib/src/js/polymer/polymer.js.map View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M pkg/polymer/pubspec.yaml View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
A pkg/polymer/test/event_binding_release_handler_test.dart View 1 2 3 1 chunk +54 lines, -0 lines 0 comments Download
A pkg/polymer/test/event_binding_release_handler_test.html View 1 2 3 1 chunk +31 lines, -0 lines 0 comments Download
M pkg/polymer/test/js_interop_test.dart View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/polymer/test/js_interop_test.html View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
M pkg/polymer/test/prop_attr_reflection_test.dart View 1 2 3 2 chunks +31 lines, -2 lines 0 comments Download
M pkg/polymer/test/prop_attr_reflection_test.html View 1 2 3 1 chunk +7 lines, -0 lines 0 comments Download
M pkg/template_binding/CHANGELOG.md View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
M pkg/template_binding/lib/src/template.dart View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M pkg/template_binding/lib/src/template_iterator.dart View 1 2 3 3 chunks +42 lines, -12 lines 0 comments Download
M pkg/template_binding/pubspec.yaml View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M pkg/template_binding/test/template_binding_test.dart View 1 2 3 2 chunks +76 lines, -0 lines 0 comments Download
M pkg/web_components/CHANGELOG.md View 1 2 3 1 chunk +8 lines, -0 lines 0 comments Download
M pkg/web_components/lib/build.log View 1 2 3 1 chunk +22 lines, -31 lines 0 comments Download
M pkg/web_components/lib/platform.js View 1 2 3 1 chunk +6 lines, -6 lines 0 comments Download
M pkg/web_components/lib/platform.concat.js View 1 2 3 120 chunks +1236 lines, -874 lines 0 comments Download
M pkg/web_components/pubspec.yaml View 1 2 3 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
jakemac
jakemac@google.com changed reviewers: + sigmund@google.com
6 years, 3 months ago (2014-08-26 21:47:36 UTC) #1
jakemac
This is mostly the same as the last roll, but with platform.js updated to the ...
6 years, 3 months ago (2014-08-26 21:47:36 UTC) #2
Siggi Cherem (dart-lang)
lgtm! just minor details below https://chromiumcodereview.appspot.com/507653004/diff/20001/pkg/polymer/pubspec.yaml File pkg/polymer/pubspec.yaml (right): https://chromiumcodereview.appspot.com/507653004/diff/20001/pkg/polymer/pubspec.yaml#newcode2 pkg/polymer/pubspec.yaml:2: version: 0.13.0 since we ...
6 years, 3 months ago (2014-08-26 22:41:39 UTC) #3
jakemac
Committed patchset #4 (id:30001) manually as 39596 (presubmit successful).
6 years, 3 months ago (2014-08-27 14:58:31 UTC) #4
jakemac
6 years, 3 months ago (2014-08-27 14:59:50 UTC) #5
Message was sent while issue was closed. 
https://chromiumcodereview.appspot.com/507653004/diff/20001/pkg/polymer/pubsp...
File pkg/polymer/pubspec.yaml (right):

https://chromiumcodereview.appspot.com/507653004/diff/20001/pkg/polymer/pubsp...
pkg/polymer/pubspec.yaml:2: version: 0.13.0
On 2014/08/26 22:41:39, Siggi Cherem (dart-lang) wrote:
> since we are going to wait for the bots before releasing it, let's mark it as
> 0.13.0-dev

Done.

https://chromiumcodereview.appspot.com/507653004/diff/20001/pkg/polymer/test/...
File pkg/polymer/test/js_interop_test.dart (right):

https://chromiumcodereview.appspot.com/507653004/diff/20001/pkg/polymer/test/...
pkg/polymer/test/js_interop_test.dart:97: test('elements can be passed through
Node.bind to JS', () {
On 2014/08/26 22:41:39, Siggi Cherem (dart-lang) wrote:
> let's move it back where it was, since that's no longer part of the issue.

Done.

https://chromiumcodereview.appspot.com/507653004/diff/20001/pkg/polymer/test/...
File pkg/polymer/test/js_interop_test.html (right):

https://chromiumcodereview.appspot.com/507653004/diff/20001/pkg/polymer/test/...
pkg/polymer/test/js_interop_test.html:50: <content hidden></content>
On 2014/08/26 22:41:39, Siggi Cherem (dart-lang) wrote:
> let's add a <!-- TODO --> here and refer to the github bug for it.

Done.

https://chromiumcodereview.appspot.com/507653004/diff/20001/pkg/web_component...
File pkg/web_components/pubspec.yaml (right):

https://chromiumcodereview.appspot.com/507653004/diff/20001/pkg/web_component...
pkg/web_components/pubspec.yaml:2: version: 0.6.0
On 2014/08/26 22:41:39, Siggi Cherem (dart-lang) wrote:
> same here (0.6.0-dev)
> 
> not sure if that will require a change in pkg/pkgbuild.status. I think not
> because we don't require this as a lowerbound from polymer, but might be a
good
> idea to double check. 

Done.

Powered by Google App Engine
This is Rietveld 408576698