Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Issue 506433002: Finish modifying analysis server to make use of code generation. (Closed)

Created:
6 years, 4 months ago by Paul Berry
Modified:
6 years, 4 months ago
Reviewers:
jwren, danrubel
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Finish modifying analysis server to make use of code generation. Generated code is used to produce the response to these requests: - analysis.updateOptions - analysis.updateContent - analysis.setSubscriptions - analysis.setPriorityFiles - analysis.setAnalysisRoots - server.shutdown - server.setSubscriptions Generated code is used to produce these requests: - server.shutdown - server.getVersion - server.shutdown - server.connected Generated code is used to produce these notifications: - completion.results - analysis.overrides - analysis.outline - analysis.occurrences Generated code is used to decode these notifications: - server.status In addition, some dead code was removed, the 'protocol.dart' and 'protocol2.dart' files were combined, and the fields Response.result, Request.params, and Notification.params were made private (to encourage future use of the generated code). Also, some overly verbose import statements were cleaned up by using "hide" rather than "show". R=danrubel@google.com Committed: https://code.google.com/p/dart/source/detail?r=39516

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1621 lines, -1364 lines) Patch
M pkg/analysis_server/lib/src/analysis_manager.dart View 2 chunks +1 line, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/analysis_server.dart View 2 chunks +2 lines, -7 lines 0 comments Download
M pkg/analysis_server/lib/src/computer/computer_highlights.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/computer/computer_hover.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/computer/computer_navigation.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/computer/computer_occurrences.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/computer/computer_outline.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/computer/computer_overrides.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/computer/element.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/computer/error.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/domain_analysis.dart View 6 chunks +5 lines, -6 lines 0 comments Download
M pkg/analysis_server/lib/src/domain_completion.dart View 2 chunks +2 lines, -10 lines 0 comments Download
M pkg/analysis_server/lib/src/domain_server.dart View 3 chunks +2 lines, -3 lines 0 comments Download
M pkg/analysis_server/lib/src/edit/edit_domain.dart View 1 chunk +1 line, -8 lines 0 comments Download
M pkg/analysis_server/lib/src/generated_protocol.dart View 150 chunks +551 lines, -138 lines 0 comments Download
M pkg/analysis_server/lib/src/operation/operation_analysis.dart View 2 chunks +8 lines, -21 lines 0 comments Download
M pkg/analysis_server/lib/src/protocol.dart View 8 chunks +880 lines, -302 lines 0 comments Download
D pkg/analysis_server/lib/src/protocol2.dart View 1 chunk +0 lines, -628 lines 0 comments Download
M pkg/analysis_server/lib/src/search/element_references.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/search/search_domain.dart View 8 chunks +13 lines, -13 lines 0 comments Download
M pkg/analysis_server/lib/src/search/search_result.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/search/type_hierarchy.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/completion/completion_manager.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart_completion_manager.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/completion/imported_type_computer.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/keyword_computer.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/completion/local_computer.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/completion/suggestion_builder.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/services/correction/assist.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/correction/assist_internal.dart View 1 chunk +1 line, -3 lines 0 comments Download
M pkg/analysis_server/lib/src/services/correction/fix.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/correction/fix_internal.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M pkg/analysis_server/lib/src/services/correction/source_buffer.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/correction/statement_analyzer.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/correction/status.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/correction/util.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/generated/completion.dart View 1 chunk +1 line, -1 line 0 comments Download
D pkg/analysis_server/lib/src/services/json.dart View 1 chunk +0 lines, -30 lines 0 comments Download
M pkg/analysis_server/lib/src/services/refactoring/extract_local.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/services/refactoring/refactoring.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/refactoring/rename.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/services/refactoring/rename_class_member.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/services/refactoring/rename_constructor.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/services/refactoring/rename_import.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/refactoring/rename_library.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/refactoring/rename_local.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/refactoring/rename_unit_member.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/analysis/get_errors_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/analysis_server/test/analysis/notification_errors_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/analysis_server/test/analysis_abstract.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/analysis_server/test/analysis_hover_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/analysis_server/test/analysis_notification_highlights_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/analysis_server/test/analysis_notification_navigation_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/analysis_server/test/analysis_notification_occurrences_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/analysis_server/test/analysis_notification_outline_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/analysis_server/test/analysis_notification_overrides_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/analysis_server/test/analysis_server_test.dart View 2 chunks +4 lines, -5 lines 0 comments Download
M pkg/analysis_server/test/channel_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/computer/element_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/computer/error_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/domain_analysis_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/analysis_server/test/domain_completion_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/analysis_server/test/domain_server_test.dart View 3 chunks +2 lines, -3 lines 0 comments Download
M pkg/analysis_server/test/edit/assists_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/analysis_server/test/edit/fixes_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/analysis_server/test/edit/refactoring_test.dart View 1 chunk +0 lines, -5 lines 0 comments Download
M pkg/analysis_server/test/protocol_test.dart View 5 chunks +8 lines, -45 lines 0 comments Download
M pkg/analysis_server/test/search/abstract_search_domain.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/analysis_server/test/search/element_references_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/analysis_server/test/search/member_declarations_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/analysis_server/test/search/member_references_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/analysis_server/test/search/search_result_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/search/top_level_declarations_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/analysis_server/test/search/type_hierarchy_test.dart View 7 chunks +6 lines, -8 lines 0 comments Download
M pkg/analysis_server/test/services/completion/completion_computer_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/services/completion/completion_test_util.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/services/completion/imported_type_computer_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/services/completion/keyword_computer_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/services/correction/assist_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/services/correction/change_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/services/correction/fix_test.dart View 1 chunk +1 line, -3 lines 0 comments Download
M pkg/analysis_server/test/services/correction/status_test.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/analysis_server/test/services/refactoring/abstract_refactoring.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/services/refactoring/abstract_rename.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/analysis_server/test/services/refactoring/extract_local_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/services/refactoring/naming_conventions_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/services/refactoring/rename_class_member_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/services/refactoring/rename_constructor_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/services/refactoring/rename_import_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/services/refactoring/rename_library_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/services/refactoring/rename_local_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/services/refactoring/rename_unit_member_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/socket_server_test.dart View 3 chunks +3 lines, -4 lines 0 comments Download
M pkg/analysis_server/tool/spec/codegen_dart_protocol.dart View 11 chunks +73 lines, -34 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Paul Berry
Sorry for the tediously long CL. I believe it's the last one like this!
6 years, 4 months ago (2014-08-24 14:26:17 UTC) #1
danrubel
lgtm
6 years, 4 months ago (2014-08-24 16:00:28 UTC) #2
Paul Berry
6 years, 4 months ago (2014-08-25 10:49:28 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as 39516 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698