pkg/analysis_server/test/socket_server_test.dart - Issue 506433002: Finish modifying analysis server to make use of code generation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_server/test/socket_server_test.dart

Issue 506433002: Finish modifying analysis server to make use of code generation. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/analysis_server/test/services/refactoring/rename_unit_member_test.dart ('k') | pkg/analysis_server/tool/spec/codegen_dart_protocol.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/analysis_server/test/socket_server_test.dart

diff --git a/pkg/analysis_server/test/socket_server_test.dart b/pkg/analysis_server/test/socket_server_test.dart

index 744a4d6c2a2fa10491b3b1c100ba0da2d8fdf0da..4ba4979d42016cbb8c47ee199adf5d735a485cc9 100644

--- a/pkg/analysis_server/test/socket_server_test.dart

+++ b/pkg/analysis_server/test/socket_server_test.dart

@@ -30,9 +30,8 @@ class SocketServerTest {

server.createAnalysisServer(channel);

channel.expectMsgCount(notificationCount: 1);

expect(channel.notificationsReceived[0].event, SERVER_CONNECTED);

- expect(channel.notificationsReceived[0].params, isNull);

return channel.sendRequest(

- new Request('0', SERVER_SHUTDOWN)

+ new ServerShutdownParams().toRequest('0')

).then((Response response) {

expect(response.id, equals('0'));

expect(response.error, isNull);

@@ -46,7 +45,6 @@ class SocketServerTest {

MockServerChannel channel2 = new MockServerChannel();

server.createAnalysisServer(channel1);

expect(channel1.notificationsReceived[0].event, SERVER_CONNECTED);

- expect(channel1.notificationsReceived[0].params, isNull);

server.createAnalysisServer(channel2);

channel1.expectMsgCount(notificationCount: 1);

channel2.expectMsgCount(responseCount: 1);

@@ -54,7 +52,8 @@ class SocketServerTest {

expect(channel2.responsesReceived[0].error, isNotNull);

expect(channel2.responsesReceived[0].error.code, equals(

RequestError.CODE_SERVER_ALREADY_STARTED));

- channel2.sendRequest(new Request('0', SERVER_SHUTDOWN)).then((Response response) {

+ channel2.sendRequest(new ServerShutdownParams().toRequest('0')).then(

+ (Response response) {

expect(response.id, equals('0'));

expect(response.error, isNotNull);

expect(response.error.code, equals(