Implement native _List. constructor in the flow-graph builder.

Implement native _List. constructor in the flow-graph builder.

Replace assembly intrinsic and the C++ native function with a CreateArray
instruction.

R=srdjan@google.com

Committed: https://code.google.com/p/dart/source/detail?r=39554

[Florian Schneider, 2014-08-25 11:51:43]

There is no noticeable performance difference and this is more universal since
we don't need neither platform-specific code special nor additional optimizer
support for inlining.

[zra, 2014-08-25 14:39:08]

+srdjan

I'm out this week, so giving this to Srdjan. Please also check that there is no
regression in Havlak with --optimization-counter-threshold=-1.

[srdjan, 2014-08-25 20:43:45]

LGTM

[Florian Schneider, 2014-08-26 13:57:23]

Committed patchset #3 manually as r39554 (presubmit successful).

[koda, 2014-08-26 21:11:37]

When I disassemble the generated code for the List constructor and AllocateArray
stub, it looks like this CL didn't change anything at all. Is that expected?

(Specifically, I'm starting at "new List" in the Leaf constructor of
SplayHarder, using --disassemble_stubs and --disassemble_optimized.)

[Florian Schneider, 2014-08-27 08:06:19]

On 2014/08/26 21:11:37, koda wrote:
> When I disassemble the generated code for the List constructor and
AllocateArray
> stub, it looks like this CL didn't change anything at all. Is that expected?
> 
> (Specifically, I'm starting at "new List" in the Leaf constructor of
> SplayHarder, using --disassemble_stubs and --disassemble_optimized.)

I did not change the stub code at all here. I changed the _List. native factory
constructor (aka "List_allocate") to be generated in terms of our IL
instructions: It is now basically a CreateArrayInstr (which itself invoked the
AllocateArray stub in this case).