Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(571)

Unified Diff: runtime/lib/array.cc

Issue 502953002: Implement native _List. constructor in the flow-graph builder. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/vm/flow_graph_builder.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/lib/array.cc
===================================================================
--- runtime/lib/array.cc (revision 39516)
+++ runtime/lib/array.cc (working copy)
@@ -13,26 +13,9 @@
namespace dart {
DEFINE_NATIVE_ENTRY(List_allocate, 2) {
- const TypeArguments& type_arguments =
- TypeArguments::CheckedHandle(isolate, arguments->NativeArgAt(0));
- const Instance& length = Instance::CheckedHandle(
- isolate, arguments->NativeArgAt(1));
- if (!length.IsSmi()) {
- const String& error = String::Handle(String::NewFormatted(
- "Length must be an integer in the range [0..%" Pd "].",
- Array::kMaxElements));
- Exceptions::ThrowArgumentError(error);
- }
- intptr_t len = Smi::Cast(length).Value();
- if (len < 0 || len > Array::kMaxElements) {
- const String& error = String::Handle(String::NewFormatted(
- "Length (%" Pd ") must be an integer in the range [0..%" Pd "].",
- len, Array::kMaxElements));
- Exceptions::ThrowArgumentError(error);
- }
- const Array& new_array = Array::Handle(Array::New(len));
- new_array.SetTypeArguments(type_arguments);
- return new_array.raw();
+ // Implemented in FlowGraphBuilder::VisitNativeBody.
+ UNREACHABLE();
+ return Object::null();
}
« no previous file with comments | « no previous file | runtime/vm/flow_graph_builder.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698