Make sure that classes in dart:html do not implement both List and List<E>.

Make sure that classes in dart:html do not implement both List and List<E>.

R=johnniwinther@google.com, blois@google.com
BUG=

Committed: https://code.google.com/p/dart/source/detail?r=29417

[Johnni Winther, 2013-10-29 07:55:35]

lgtm

[rakudrama, 2013-10-29 08:29:55]

Get Pete's feedback.
This change does not work for

List<CanvasElement> x = document.queryAll(...);

The returned NodeList fails the type assertion in checked mode.

[kasperl, 2013-10-29 08:37:22]

Committed patchset #1 manually as r29417 (presubmit successful).

[kasperl, 2013-10-29 12:12:25]

On 2013/10/29 08:29:55, rakudrama wrote:
> Get Pete's feedback.
> This change does not work for
> 
> List<CanvasElement> x = document.queryAll(...);
> 
> The returned NodeList fails the type assertion in checked mode.

Having though a little bit more about this, I'm not sure I understand your
concerns, Stephen. The document.queryAll function returns a "raw"
FrozenElementList so what is returned implements a "raw" List. Clearly, that can
be assigned to something with a List<CanvasElement> type annotation in checked
mode. The change hasn't been reverted yet so it's still cooking on the build
bots.

Cheers,
Kasper

[blois, 2013-10-29 16:19:29]

On 2013/10/29 12:12:25, kasperl wrote:
> On 2013/10/29 08:29:55, rakudrama wrote:
> > Get Pete's feedback.
> > This change does not work for
> > 
> > List<CanvasElement> x = document.queryAll(...);
> > 
> > The returned NodeList fails the type assertion in checked mode.
> 
> Having though a little bit more about this, I'm not sure I understand your
> concerns, Stephen. The document.queryAll function returns a "raw"
> FrozenElementList so what is returned implements a "raw" List. Clearly, that
can
> be assigned to something with a List<CanvasElement> type annotation in checked
> mode. The change hasn't been reverted yet so it's still cooking on the build
> bots.
> 
> Cheers,
> Kasper

I think the issue was that there are a number of places where we return NodeList
as a List<Node> (for example getElementsByClassName), where it is a fairly safe
assumption that the  list will only have a sub-type.

We only removed the types on these items 2 weeks ago and it should not be a
breaking change to make this change again in the future (if needed), so I'm OK
reversing it now.