tools/dom/scripts/htmldartgenerator.py - Issue 50263004: Make sure that classes in dart:html do not implement both List and List<E>.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/dom/scripts/htmldartgenerator.py

Issue 50263004: Make sure that classes in dart:html do not implement both List and List<E>. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/dom/scripts/htmldartgenerator.py

diff --git a/tools/dom/scripts/htmldartgenerator.py b/tools/dom/scripts/htmldartgenerator.py

index 8205dad1ed56eeda411ab87e5f2a7e451f4536f6..d549d981154a9873480fb08c25e0c4f30d76cc3a 100644

--- a/tools/dom/scripts/htmldartgenerator.py

+++ b/tools/dom/scripts/htmldartgenerator.py

@@ -445,9 +445,9 @@ class HtmlDartGenerator(object):

# TODO: Include all implemented interfaces, including other Lists.

implements = []

if self._interface_type_info.list_item_type():

- item_type_info = self._type_registry.TypeInfo(

- self._interface_type_info.list_item_type())

- implements.append('List')

+ item_type = self._type_registry.TypeInfo(

+ self._interface_type_info.list_item_type()).dart_type()

+ implements.append('List<%s>' % item_type)

return implements

def Mixins(self):

« no previous file with comments | « sdk/lib/web_sql/dartium/web_sql_dartium.dart ('k') | tools/dom/templates/html/impl/impl_Element.darttemplate » ('j') | no next file with comments »