Extend Observatory to display libraries, classes, fields, functions and code.

Extend Observatory to display libraries, classes, fields, functions and code.

R=sethladd@google.com

Committed: https://code.google.com/p/dart/source/detail?r=29622

[Cutch, 2013-10-29 07:05:20]

Seth & Justin,

This CL is pure Polymer changes, PTAL.

john

[sethladd, 2013-10-30 22:45:01]

I didn't look at every line, but would suggest moving to explicit show for each
import.

https://codereview.chromium.org/50243002/diff/220002/runtime/bin/vmservice/cl...
File runtime/bin/vmservice/client/lib/observatory.dart (right):

https://codereview.chromium.org/50243002/diff/220002/runtime/bin/vmservice/cl...
runtime/bin/vmservice/client/lib/observatory.dart:6: import 'dart:mirrors';
have you investigated mirrorsused? What is the size of your app when compiled?

also, we are moving to import foo show bar. Please add show to your imports next
time you go into .dart files.

[sethladd, 2013-10-30 22:48:19]

lgtm

[Ivan Posva, 2013-10-30 22:57:08]

https://codereview.chromium.org/50243002/diff/220002/runtime/bin/vmservice/cl...
File runtime/bin/vmservice/client/lib/observatory.dart (right):

https://codereview.chromium.org/50243002/diff/220002/runtime/bin/vmservice/cl...
runtime/bin/vmservice/client/lib/observatory.dart:6: import 'dart:mirrors';
John,

I must be missing something as I did not see any use of mirrors in the new code
being added here.

-Ivan

[Cutch, 2013-10-31 00:35:28]

On 2013/10/30 22:57:08, Ivan Posva wrote:
>
https://codereview.chromium.org/50243002/diff/220002/runtime/bin/vmservice/cl...
> File runtime/bin/vmservice/client/lib/observatory.dart (right):
> 
>
https://codereview.chromium.org/50243002/diff/220002/runtime/bin/vmservice/cl...
> runtime/bin/vmservice/client/lib/observatory.dart:6: import 'dart:mirrors';
> John,
> 
> I must be missing something as I did not see any use of mirrors in the new
code
> being added here.

No, but, while testing it I couldn't get the dart2js version to run without
adding the dart:mirrors import (effectively disabling the mirrorsUsed
optimization in dart2js). However, I must have been fighting another issue
because it's working fine now. New Patch Set removes the import. Including a
massive dart2js code size drop from 2.6MB to 650k.

[Cutch, 2013-10-31 01:27:19]

Committed patchset #4 manually as r29622 (presubmit successful).