runtime/bin/vmservice/client/lib/src/observatory_elements/message_viewer.dart - Issue 50243002: Extend Observatory to display libraries, classes, fields, functions and code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/bin/vmservice/client/lib/src/observatory_elements/message_viewer.dart

Issue 50243002: Extend Observatory to display libraries, classes, fields, functions and code. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « runtime/bin/vmservice/client/lib/src/observatory_elements/library_view.html ('k') | runtime/bin/vmservice/client/lib/src/observatory_elements/message_viewer.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: runtime/bin/vmservice/client/lib/src/observatory_elements/message_viewer.dart

diff --git a/runtime/bin/vmservice/client/lib/src/observatory_elements/message_viewer.dart b/runtime/bin/vmservice/client/lib/src/observatory_elements/message_viewer.dart

index cc85580e1d16096db16a6b20e8158cc047407de8..10342aabc5a69dc7685a953f06ed9235039a44f8 100644

--- a/runtime/bin/vmservice/client/lib/src/observatory_elements/message_viewer.dart

+++ b/runtime/bin/vmservice/client/lib/src/observatory_elements/message_viewer.dart

@@ -14,10 +14,12 @@ class MessageViewerElement extends ObservatoryElement {

@published set message(Map m) {

_message = m;

- this.notifyPropertyChange(#messageType, null, null);

- this.notifyPropertyChange(#members, null, null);

+ notifyPropertyChange(#messageType, "", messageType);

+ notifyPropertyChange(#members, [], members);

}

+ MessageViewerElement.created() : super.created();

String get messageType {

if (message == null || message['type'] == null) {

return 'Error';