Issue 50073007: fix barback and polymer build warnings

Issue 50073007: fix barback and polymer build warnings (Closed)

Created:
7 years, 1 month ago by Jennifer Messerly

Modified:
7 years, 1 month ago

Reviewers:
nweiz, Siggi Cherem (dart-lang)

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

fix barback and polymer build warnings R=nweiz@google.com, sigmund@google.com Committed: https://code.google.com/p/dart/source/detail?r=29631

Patch Set 1 #

Total comments: 3

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+42 lines, -74 lines)			Patch
M	pkg/barback/lib/src/asset_cascade.dart	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	pkg/barback/lib/src/phase_input.dart	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	pkg/barback/lib/src/utils.dart	View	1 chunk	+2 lines, -1 line	1 comment	Download
M	pkg/barback/test/utils.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/pkg.status	View	2 chunks	+0 lines, -42 lines	0 comments	Download
M	pkg/polymer/lib/src/build/common.dart	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	pkg/polymer/lib/src/build/import_inliner.dart	View	3 chunks	+7 lines, -4 lines	1 comment	Download
M	pkg/polymer/lib/src/build/linter.dart	View	4 chunks	+4 lines, -4 lines	0 comments	Download
M	pkg/polymer/lib/src/build/polyfill_injector.dart	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	pkg/polymer/lib/src/build/script_compactor.dart	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	pkg/scheduled_test/lib/scheduled_process.dart	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	pkg/scheduled_test/lib/src/mock_clock.dart	View	3 chunks	+8 lines, -3 lines	1 comment	Download
M	pkg/scheduled_test/lib/src/schedule.dart	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	pkg/scheduled_test/lib/src/task.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/scheduled_test/test/descriptor/utils.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/scheduled_test/test/scheduled_process_test.dart	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Jennifer Messerly

Hey guys, this static fixes warnings in barback/scheduled_test/polymer build. Have a look! :) It caught ...

7 years, 1 month ago (2013-10-30 00:59:28 UTC) #1

Siggi Cherem (dart-lang)

lgtm https://codereview.chromium.org/50073007/diff/1/pkg/polymer/lib/src/build/import_inliner.dart File pkg/polymer/lib/src/build/import_inliner.dart (right): https://codereview.chromium.org/50073007/diff/1/pkg/polymer/lib/src/build/import_inliner.dart#newcode211 pkg/polymer/lib/src/build/import_inliner.dart:211: // Techincally we shouldn't get there love the ...

7 years, 1 month ago (2013-10-30 01:12:39 UTC) #2

nweiz

lgtm https://codereview.chromium.org/50073007/diff/1/pkg/scheduled_test/lib/src/mock_clock.dart File pkg/scheduled_test/lib/src/mock_clock.dart (right): https://codereview.chromium.org/50073007/diff/1/pkg/scheduled_test/lib/src/mock_clock.dart#newcode35 pkg/scheduled_test/lib/src/mock_clock.dart:35: /// Returns a new (possibly mocked) [Timer]. Works ...

7 years, 1 month ago (2013-10-30 19:28:39 UTC) #3

Jennifer Messerly

7 years, 1 month ago (2013-10-31 02:41:11 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r29631 (presubmit successful).

Expand Messages | Collapse Messages