Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Unified Diff: pkg/polymer/lib/src/build/common.dart

Issue 50073007: fix barback and polymer build warnings (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/polymer/lib/src/build/common.dart
diff --git a/pkg/polymer/lib/src/build/common.dart b/pkg/polymer/lib/src/build/common.dart
index 743b80b938f52c849e2611342d55b133a5312606..672456111f9382562b05b75388487aa339dc2bc5 100644
--- a/pkg/polymer/lib/src/build/common.dart
+++ b/pkg/polymer/lib/src/build/common.dart
@@ -115,7 +115,7 @@ AssetId resolve(AssetId source, String url, TransformLogger logger, Span span) {
var uri = Uri.parse(url);
var urlBuilder = path.url;
if (uri.host != '' || uri.scheme != '' || urlBuilder.isAbsolute(url)) {
- logger.error('absolute paths not allowed: "$url"', span);
+ logger.error('absolute paths not allowed: "$url"', span: span);
return null;
}
@@ -125,7 +125,7 @@ AssetId resolve(AssetId source, String url, TransformLogger logger, Span span) {
if (segments[0] == 'packages') {
if (segments.length < 3) {
logger.error("incomplete packages/ path. It should have at least 3 "
- "segments packages/name/path-from-name's-lib-dir", span);
+ "segments packages/name/path-from-name's-lib-dir", span: span);
return null;
}
package = segments[1];
@@ -134,7 +134,7 @@ AssetId resolve(AssetId source, String url, TransformLogger logger, Span span) {
} else if (segments[0] == 'assets') {
if (segments.length < 3) {
logger.error("incomplete assets/ path. It should have at least 3 "
- "segments assets/name/path-from-name's-asset-dir", span);
+ "segments assets/name/path-from-name's-asset-dir", span: span);
}
package = segments[1];
targetPath = urlBuilder.join('asset',

Powered by Google App Engine
This is Rietveld 408576698