Issue 500093003: Remove service.Class.children, and (mostly) as a side-effect sort the class hierarchy view.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 500093003: Remove service.Class.children, and (mostly) as a side-effect sort the class hierarchy view. (Closed)

Created:
6 years, 4 months ago by rmacnak

Modified:
6 years, 4 months ago

Reviewers:
turnidge, Cutch

CC:
reviews_dartlang.org, turnidge, Cutch, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Remove service.Class.children, and (mostly) as a side-effect sort the class hierarchy view. Fix spelling of superclass and subclass. Remove redudant null check in JSONifying classes. BUG=http://dartbug.com/20554 R=johnmccutchan@google.com, turnidge@google.com Committed: https://code.google.com/p/dart/source/detail?r=39532

Created: 6 years, 4 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+40 lines, -40 lines)			Patch
M	runtime/bin/vmservice/observatory/deployed/web/index.html	View	1 2	1 chunk	+4 lines, -4 lines	0 comments	Download
M	runtime/bin/vmservice/observatory/deployed/web/index_devtools.html	View	1 2	1 chunk	+4 lines, -4 lines	0 comments	Download
M	runtime/bin/vmservice/observatory/deployed/web/packages/observatory/src/elements/class_view.html	View	1 2	1 chunk	+4 lines, -4 lines	0 comments	Download
M	runtime/bin/vmservice/observatory/lib/src/elements/class_tree.dart	View	2	2 chunks	+4 lines, -4 lines	0 comments	Download
M	runtime/bin/vmservice/observatory/lib/src/elements/class_view.html	View	2	1 chunk	+4 lines, -4 lines	0 comments	Download
M	runtime/bin/vmservice/observatory/lib/src/service/object.dart	View	1 2	6 chunks	+15 lines, -13 lines	0 comments	Download
M	runtime/vm/object.cc	View	1 2	1 chunk	+5 lines, -7 lines	0 comments	Download

Total messages: 4 (0 generated)

rmacnak

6 years, 4 months ago (2014-08-25 21:32:09 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 manually as 39532 (presubmit successful).