runtime/bin/vmservice/observatory/lib/src/elements/class_tree.dart - Issue 500093003: Remove service.Class.children, and (mostly) as a side-effect sort the class hierarchy view.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/bin/vmservice/observatory/lib/src/elements/class_tree.dart

Issue 500093003: Remove service.Class.children, and (mostly) as a side-effect sort the class hierarchy view. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: build Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « runtime/bin/vmservice/observatory/deployed/web/packages/observatory/src/elements/class_view.html ('k') | runtime/bin/vmservice/observatory/lib/src/elements/class_view.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: runtime/bin/vmservice/observatory/lib/src/elements/class_tree.dart

diff --git a/runtime/bin/vmservice/observatory/lib/src/elements/class_tree.dart b/runtime/bin/vmservice/observatory/lib/src/elements/class_tree.dart

index c4d16132ddb926b9364de8c2dce1c406f658f815..c9e11532f06398fc256b285da5558a9f9c14e611 100644

--- a/runtime/bin/vmservice/observatory/lib/src/elements/class_tree.dart

+++ b/runtime/bin/vmservice/observatory/lib/src/elements/class_tree.dart

@@ -24,11 +24,11 @@ class ClassTreeRow extends TableTreeRow {

// Child rows already created.

return;

}

- for (var subClass in cls.children) {

- if (subClass.isPatch) {

+ for (var subclass in cls.subclasses) {

+ if (subclass.isPatch) {

continue;

}

- var row = new ClassTreeRow(isolate, subClass, this);

+ var row = new ClassTreeRow(isolate, subclass, this);

children.add(row);

}

@@ -37,7 +37,7 @@ class ClassTreeRow extends TableTreeRow {

}

bool hasChildren() {

- return cls.children.length > 0;

+ return cls.subclasses.length > 0;

}