Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issue 49743005: Issue 13449. Bind parameters to arguments and check for function expression invocation. (Closed)

Created:
7 years, 1 month ago by scheglov
Modified:
7 years, 1 month ago
Reviewers:
jwren, Brian Wilkerson
CC:
reviews_dartlang.org, lukeechurch_gmail.com
Visibility:
Public.

Description

Issue 13449. Bind parameters to arguments and check for function expression invocation. https://code.google.com/p/dart/issues/detail?id=13449 Also some co19 triage. R=brianwilkerson@google.com, jwren@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=29457

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -25 lines) Patch
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/ElementResolver.java View 2 chunks +14 lines, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/StaticWarningCodeTest.java View 3 chunks +31 lines, -0 lines 0 comments Download
M tests/co19/co19-analyzer.status View 2 chunks +37 lines, -24 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
7 years, 1 month ago (2013-10-29 04:33:50 UTC) #1
Brian Wilkerson
LGTM
7 years, 1 month ago (2013-10-29 14:02:18 UTC) #2
scheglov
7 years, 1 month ago (2013-10-29 16:45:37 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r29457 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698