editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/ElementResolver.java - Issue 49743005: Issue 13449. Bind parameters to arguments and check for function expression invocation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/ElementResolver.java

Issue 49743005: Issue 13449. Bind parameters to arguments and check for function expression invocation. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/StaticWarningCodeTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/ElementResolver.java

diff --git a/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/ElementResolver.java b/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/ElementResolver.java

index 768b45610d3235b058337ce92fafb8a236fd7ab2..4592378ab2f198e8455c5252f9430069b22ae59e 100644

--- a/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/ElementResolver.java

+++ b/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/ElementResolver.java

@@ -38,6 +38,7 @@ import com.google.dart.engine.ast.Expression;

import com.google.dart.engine.ast.FieldDeclaration;

import com.google.dart.engine.ast.FieldFormalParameter;

import com.google.dart.engine.ast.FunctionDeclaration;

+import com.google.dart.engine.ast.FunctionExpression;

import com.google.dart.engine.ast.FunctionExpressionInvocation;

import com.google.dart.engine.ast.FunctionTypeAlias;

import com.google.dart.engine.ast.HideCombinator;

@@ -763,7 +764,19 @@ public class ElementResolver extends SimpleASTVisitor<Void> {

@Override

public Void visitFunctionExpressionInvocation(FunctionExpressionInvocation node) {

// TODO(brianwilkerson) Can we ever resolve the function being invoked?

- //resolveArgumentsToParameters(node.getArgumentList(), invokedFunction);

+ Expression expression = node.getFunction();

+ if (expression instanceof FunctionExpression) {

+ FunctionExpression functionExpression = (FunctionExpression) expression;

+ ExecutableElement functionElement = functionExpression.getElement();

+ ArgumentList argumentList = node.getArgumentList();

+ ParameterElement[] parameters = resolveArgumentsToParameters(

+ false,

+ argumentList,

+ functionElement);

+ if (parameters != null) {

+ argumentList.setCorrespondingStaticParameters(parameters);

+ }

return null;

}