Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 496483002: Moves SingleStepHandler runtime calls (Closed)

Created:
6 years, 4 months ago by zra
Modified:
6 years, 4 months ago
Reviewers:
srdjan
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Moves SingleStepHandler runtime calls to match the NArgsCheckInlineCache stub. Gives a small improvement in unoptimized code. R=srdjan@google.com Committed: https://code.google.com/p/dart/source/detail?r=39417

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+163 lines, -137 lines) Patch
M runtime/vm/stub_code_arm.cc View 6 chunks +28 lines, -24 lines 0 comments Download
M runtime/vm/stub_code_arm64.cc View 6 chunks +30 lines, -24 lines 0 comments Download
M runtime/vm/stub_code_ia32.cc View 6 chunks +31 lines, -26 lines 0 comments Download
M runtime/vm/stub_code_mips.cc View 7 chunks +43 lines, -38 lines 0 comments Download
M runtime/vm/stub_code_x64.cc View 6 chunks +31 lines, -25 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
zra
6 years, 4 months ago (2014-08-20 17:12:01 UTC) #1
srdjan
lgtm
6 years, 4 months ago (2014-08-20 17:29:06 UTC) #2
zra
6 years, 4 months ago (2014-08-20 18:21:53 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r39417 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698