Issue 494623002: Implement diff algorithm for libraries.

Issue 494623002: Implement diff algorithm for libraries. (Closed)

Created:
6 years, 4 months ago by ahe

Modified:
6 years, 3 months ago

Reviewers:
Johnni Winther

CC:
reviews_dartlang.org, sra1, kasperl, lukechurch

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Implement diff algorithm for libraries. R=johnniwinther@google.com Committed: https://code.google.com/p/dart/source/detail?r=39551

Patch Set 2 : Merged with r39546. #

Total comments: 4

Patch Set 3 : Address comments. #

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+291 lines, -22 lines)			Patch
M	dart/sdk/lib/_internal/compiler/implementation/library_loader.dart	View	1 2	1 chunk	+26 lines, -16 lines	0 comments	Download
M	dart/sdk/lib/_internal/compiler/implementation/scanner/listener.dart	View	1	3 chunks	+8 lines, -6 lines	0 comments	Download
A	dart/site/try/poi/diff.dart	View		1 chunk	+134 lines, -0 lines	0 comments	Download
A	dart/tests/try/poi/diff_test.dart	View		1 chunk	+123 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Johnni Winther

lgtm https://codereview.chromium.org/494623002/diff/40001/dart/sdk/lib/_internal/compiler/implementation/library_loader.dart File dart/sdk/lib/_internal/compiler/implementation/library_loader.dart (right): https://codereview.chromium.org/494623002/diff/40001/dart/sdk/lib/_internal/compiler/implementation/library_loader.dart#newcode505 dart/sdk/lib/_internal/compiler/implementation/library_loader.dart:505: return processLibraryTags(handler, element).then((_) { This should be de-indented. ...

6 years, 3 months ago (2014-08-26 12:31:03 UTC) #3

ahe

Thank you, Johnni! https://codereview.chromium.org/494623002/diff/40001/dart/sdk/lib/_internal/compiler/implementation/library_loader.dart File dart/sdk/lib/_internal/compiler/implementation/library_loader.dart (right): https://codereview.chromium.org/494623002/diff/40001/dart/sdk/lib/_internal/compiler/implementation/library_loader.dart#newcode505 dart/sdk/lib/_internal/compiler/implementation/library_loader.dart:505: return processLibraryTags(handler, element).then((_) { On 2014/08/26 ...

6 years, 3 months ago (2014-08-26 13:01:34 UTC) #4

ahe

6 years, 3 months ago (2014-08-26 13:01:47 UTC) #5

Message was sent while issue was closed.

Committed patchset #3 manually as 39551 (presubmit successful).

Expand Messages | Collapse Messages