Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Unified Diff: dart/sdk/lib/_internal/compiler/implementation/scanner/listener.dart

Issue 494623002: Implement diff algorithm for libraries. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: Address comments. Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « dart/sdk/lib/_internal/compiler/implementation/library_loader.dart ('k') | dart/site/try/poi/diff.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dart/sdk/lib/_internal/compiler/implementation/scanner/listener.dart
diff --git a/dart/sdk/lib/_internal/compiler/implementation/scanner/listener.dart b/dart/sdk/lib/_internal/compiler/implementation/scanner/listener.dart
index 234352bb34ebbbbe94472ac255dcfa1b59656203..468473e83ce82e52cfa35ac656ef36823932590a 100644
--- a/dart/sdk/lib/_internal/compiler/implementation/scanner/listener.dart
+++ b/dart/sdk/lib/_internal/compiler/implementation/scanner/listener.dart
@@ -2169,7 +2169,7 @@ class NodeListener extends ElementListener {
}
}
-abstract class PartialElement implements Element {
+abstract class PartialElement {
Token get beginToken;
Token get endToken;
@@ -2254,16 +2254,17 @@ class PartialConstructorElement extends ConstructorElementX
}
}
-class PartialFieldList extends VariableList {
+class PartialFieldList extends VariableList with PartialElement {
final Token beginToken;
final Token endToken;
- final bool hasParseError;
PartialFieldList(this.beginToken,
this.endToken,
Modifiers modifiers,
- this.hasParseError)
- : super(modifiers);
+ bool hasParseError)
+ : super(modifiers) {
+ super.hasParseError = hasParseError;
+ }
VariableDefinitions parseNode(Element element, DiagnosticListener listener) {
if (definitions != null) return definitions;
@@ -2365,7 +2366,8 @@ Node parse(DiagnosticListener diagnosticListener,
doParse(new Parser(listener));
} on ParserError catch (e) {
if (element is PartialElement) {
- element.hasParseError = true;
+ PartialElement partial = element as PartialElement;
+ partial.hasParseError = true;
}
return new ErrorNode(element.position, e.reason);
}
« no previous file with comments | « dart/sdk/lib/_internal/compiler/implementation/library_loader.dart ('k') | dart/site/try/poi/diff.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698