Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 492563002: Make more use of generated classes in analysis server. (Closed)

Created:
6 years, 4 months ago by Paul Berry
Modified:
6 years, 4 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Make more use of generated classes in analysis server. Generated code is now used to process input JSON, and to create requests and process responses in unit tests. In addition, the handwritten classes for ElementKind and SourceEdit have been replaced with the gennerated versions. Also some dead code has been removed. R=scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=39404

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+421 lines, -1158 lines) Patch
M pkg/analysis_server/lib/src/analysis_server.dart View 3 chunks +19 lines, -20 lines 0 comments Download
M pkg/analysis_server/lib/src/computer/computer_outline.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analysis_server/lib/src/computer/element.dart View 4 chunks +45 lines, -97 lines 0 comments Download
M pkg/analysis_server/lib/src/domain_analysis.dart View 7 chunks +14 lines, -74 lines 0 comments Download
M pkg/analysis_server/lib/src/domain_completion.dart View 2 chunks +7 lines, -6 lines 0 comments Download
M pkg/analysis_server/lib/src/edit/edit_domain.dart View 4 chunks +16 lines, -14 lines 2 comments Download
M pkg/analysis_server/lib/src/generated_protocol.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/protocol.dart View 3 chunks +0 lines, -285 lines 0 comments Download
M pkg/analysis_server/lib/src/protocol2.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/search/search_domain.dart View 7 chunks +18 lines, -16 lines 0 comments Download
M pkg/analysis_server/lib/src/services/correction/assist_internal.dart View 12 chunks +13 lines, -12 lines 0 comments Download
M pkg/analysis_server/lib/src/services/correction/change.dart View 5 chunks +24 lines, -94 lines 0 comments Download
M pkg/analysis_server/lib/src/services/correction/fix_internal.dart View 4 chunks +4 lines, -3 lines 0 comments Download
M pkg/analysis_server/lib/src/services/correction/util.dart View 2 chunks +4 lines, -3 lines 0 comments Download
M pkg/analysis_server/lib/src/services/refactoring/rename.dart View 4 chunks +6 lines, -4 lines 0 comments Download
M pkg/analysis_server/lib/src/services/refactoring/rename_class_member.dart View 2 chunks +5 lines, -4 lines 0 comments Download
M pkg/analysis_server/lib/src/services/refactoring/rename_constructor.dart View 2 chunks +2 lines, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/refactoring/rename_import.dart View 3 chunks +6 lines, -5 lines 0 comments Download
M pkg/analysis_server/test/analysis/get_errors_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/analysis_hover_test.dart View 12 chunks +21 lines, -25 lines 0 comments Download
M pkg/analysis_server/test/analysis_notification_navigation_test.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analysis_server/test/analysis_notification_occurrences_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/analysis_notification_outline_test.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analysis_server/test/computer/element_test.dart View 2 chunks +40 lines, -38 lines 0 comments Download
M pkg/analysis_server/test/domain_completion_test.dart View 2 chunks +3 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/edit/assists_test.dart View 3 chunks +8 lines, -11 lines 0 comments Download
M pkg/analysis_server/test/edit/fixes_test.dart View 2 chunks +8 lines, -8 lines 0 comments Download
M pkg/analysis_server/test/edit/refactoring_test.dart View 4 chunks +8 lines, -7 lines 0 comments Download
M pkg/analysis_server/test/protocol_test.dart View 4 chunks +1 line, -281 lines 0 comments Download
M pkg/analysis_server/test/search/abstract_search_domain.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/search/element_references_test.dart View 2 chunks +5 lines, -5 lines 0 comments Download
M pkg/analysis_server/test/search/member_declarations_test.dart View 2 chunks +4 lines, -3 lines 0 comments Download
M pkg/analysis_server/test/search/member_references_test.dart View 2 chunks +2 lines, -3 lines 0 comments Download
M pkg/analysis_server/test/search/search_result_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analysis_server/test/search/top_level_declarations_test.dart View 2 chunks +4 lines, -3 lines 0 comments Download
M pkg/analysis_server/test/search/type_hierarchy_test.dart View 14 chunks +75 lines, -75 lines 0 comments Download
M pkg/analysis_server/test/services/correction/assist_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/services/correction/change_test.dart View 6 chunks +36 lines, -41 lines 0 comments Download
M pkg/analysis_server/test/services/correction/fix_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/services/refactoring/abstract_rename.dart View 5 chunks +6 lines, -5 lines 0 comments Download
M pkg/analysis_server/tool/spec/codegen_dart_protocol.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Paul Berry
6 years, 4 months ago (2014-08-19 22:09:20 UTC) #1
scheglov
LGTM https://codereview.chromium.org/492563002/diff/1/pkg/analysis_server/lib/src/edit/edit_domain.dart File pkg/analysis_server/lib/src/edit/edit_domain.dart (right): https://codereview.chromium.org/492563002/diff/1/pkg/analysis_server/lib/src/edit/edit_domain.dart#newcode70 pkg/analysis_server/lib/src/edit/edit_domain.dart:70: // TODO(paulberry): params.length isn't used. Is this a ...
6 years, 4 months ago (2014-08-20 05:40:39 UTC) #2
Paul Berry
6 years, 4 months ago (2014-08-20 12:39:55 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 manually as 39404 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698