Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2500)

Unified Diff: pkg/analysis_server/lib/src/domain_completion.dart

Issue 492563002: Make more use of generated classes in analysis server. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/lib/src/domain_completion.dart
diff --git a/pkg/analysis_server/lib/src/domain_completion.dart b/pkg/analysis_server/lib/src/domain_completion.dart
index ed7c26b2beb7b6d4514320d52ca56d45ce1a40df..258c9a4e57dca27c57c928180ce684eee37de309 100644
--- a/pkg/analysis_server/lib/src/domain_completion.dart
+++ b/pkg/analysis_server/lib/src/domain_completion.dart
@@ -7,6 +7,8 @@ library domain.completion;
import 'package:analysis_server/src/analysis_server.dart';
import 'package:analysis_server/src/constants.dart';
import 'package:analysis_server/src/protocol.dart';
+import 'package:analysis_server/src/protocol2.dart' show
+ CompletionGetSuggestionsParams;
import 'package:analysis_server/src/services/completion/completion_manager.dart';
import 'package:analysis_server/src/services/completion/completion_suggestion.dart';
@@ -47,15 +49,14 @@ class CompletionDomainHandler implements RequestHandler {
* Process a `completion.getSuggestions` request.
*/
Response processRequest(Request request) {
- // extract param
- String file = request.getRequiredParameter(FILE).asString();
- int offset = request.getRequiredParameter(OFFSET).asInt();
+ // extract params
+ var params = new CompletionGetSuggestionsParams.fromRequest(request);
// schedule completion analysis
String completionId = (_nextCompletionId++).toString();
CompletionManager.create(
- server.getAnalysisContext(file),
- server.getSource(file),
- offset,
+ server.getAnalysisContext(params.file),
+ server.getSource(params.file),
+ params.offset,
server.searchEngine).results().listen((CompletionResult result) {
sendCompletionNotification(
completionId,

Powered by Google App Engine
This is Rietveld 408576698