Issue 48993007: Revise barback logging patch.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 48993007: Revise barback logging patch. (Closed)

Created:
7 years, 1 month ago by Bob Nystrom

Modified:
7 years, 1 month ago

Reviewers:
nweiz

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Revise barback logging patch. R=nweiz@google.com Committed: https://code.google.com/p/dart/source/detail?r=29483

Patch Set 1 #

Patch Set 2 : Revise. #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+132 lines, -195 lines)			Patch
M	pkg/barback/lib/barback.dart	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/barback/lib/src/asset_cascade.dart	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	pkg/barback/lib/src/barback.dart	View	1	2 chunks	+9 lines, -3 lines	0 comments	Download
M	pkg/barback/lib/src/barback_logger.dart	View	1	1 chunk	+0 lines, -59 lines	0 comments	Download
M	pkg/barback/lib/src/build_result.dart	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	pkg/barback/lib/src/file_pool.dart	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	pkg/barback/lib/src/group_runner.dart	View	1	2 chunks	+3 lines, -3 lines	0 comments	Download
A +	pkg/barback/lib/src/log.dart	View	1	3 chunks	+3 lines, -22 lines	0 comments	Download
M	pkg/barback/lib/src/package_graph.dart	View	1	5 chunks	+23 lines, -8 lines	0 comments	Download
M	pkg/barback/lib/src/phase.dart	View	1	2 chunks	+3 lines, -6 lines	0 comments	Download
M	pkg/barback/lib/src/phase_forwarder.dart	View	1	1 chunk	+0 lines, -2 lines	0 comments	Download
M	pkg/barback/lib/src/phase_input.dart	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/barback/lib/src/pool.dart	View	1	1 chunk	+6 lines, -0 lines	0 comments	Download
M	pkg/barback/lib/src/transform.dart	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/barback/lib/src/transform_logger.dart	View	1	4 chunks	+7 lines, -7 lines	0 comments	Download
M	pkg/barback/lib/src/transform_node.dart	View	1	2 chunks	+1 line, -2 lines	0 comments	Download
M	pkg/barback/lib/src/transformer_group.dart	View	1	1 chunk	+0 lines, -2 lines	0 comments	Download
M	pkg/barback/lib/src/utils.dart	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	sdk/lib/_internal/pub/lib/src/barback.dart	View	1	3 chunks	+57 lines, -3 lines	0 comments	Download
M	sdk/lib/_internal/pub/lib/src/barback/dart2js_transformer.dart	View		1 chunk	+5 lines, -6 lines	0 comments	Download
M	sdk/lib/_internal/pub/lib/src/barback/pub_barback_logger.dart	View	1	1 chunk	+0 lines, -63 lines	0 comments	Download
M	sdk/lib/_internal/pub/lib/src/dart.dart	View		2 chunks	+10 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Bob Nystrom

7 years, 1 month ago (2013-10-29 20:01:29 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r29483 (presubmit successful).

Expand Messages | Collapse Messages