Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2191)

Unified Diff: pkg/barback/lib/src/log.dart

Issue 48993007: Revise barback logging patch. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Revise. Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/barback/lib/src/group_runner.dart ('k') | pkg/barback/lib/src/package_graph.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/barback/lib/src/log.dart
diff --git a/pkg/barback/lib/src/barback_logger.dart b/pkg/barback/lib/src/log.dart
similarity index 61%
rename from pkg/barback/lib/src/barback_logger.dart
rename to pkg/barback/lib/src/log.dart
index c343c594f3e58db342ebf658da7495d53cb29160..809d8a91ffa9d334e4e99c776702e16c39a6efd6 100644
--- a/pkg/barback/lib/src/barback_logger.dart
+++ b/pkg/barback/lib/src/log.dart
@@ -2,32 +2,13 @@
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
-library barback.barback_logger;
+library barback.log;
import 'package:source_maps/span.dart';
import 'asset_id.dart';
import 'errors.dart';
-/// Object used to report warnings and errors encountered while running a
-/// transformer.
-class BarbackLogger {
- /// Logs [entry].
- void logEntry(LogEntry entry) {
- var buffer = new StringBuffer();
- buffer.write("[${entry.level} ${entry.transform}] ");
-
- var message = entry.message;
- if (entry.span == null) {
- buffer.write(entry.span.getLocationMessage(entry.message));
- } else {
- buffer.write(message);
- }
-
- print(buffer);
- }
-}
-
/// The severity of a logged message.
class LogLevel {
static const INFO = const LogLevel("Info");
@@ -46,7 +27,7 @@ class LogEntry {
final TransformInfo transform;
/// The asset that the message is associated with.
- final AssetId asset;
+ final AssetId assetId;
final LogLevel level;
final String message;
@@ -55,5 +36,5 @@ class LogEntry {
/// a source [Span].
final Span span;
- LogEntry(this.transform, this.asset, this.level, this.message, this.span);
+ LogEntry(this.transform, this.assetId, this.level, this.message, this.span);
}
« no previous file with comments | « pkg/barback/lib/src/group_runner.dart ('k') | pkg/barback/lib/src/package_graph.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698