Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 488233003: More service api cleanup. camelCasePropertyNames (Closed)

Created:
6 years, 3 months ago by turnidge
Modified:
6 years, 3 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, Cutch, vm-dev_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : gen js, etc. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17826 lines, -18262 lines) Patch
M runtime/bin/vmservice/observatory/deployed/web/index.html View 1 2 3 4 5 chunks +16 lines, -15 lines 0 comments Download
M runtime/bin/vmservice/observatory/deployed/web/index.html_bootstrap.dart.js View 1 2 3 4 396 chunks +8845 lines, -9064 lines 0 comments Download
M runtime/bin/vmservice/observatory/deployed/web/index_devtools.html View 1 2 3 4 5 chunks +16 lines, -15 lines 0 comments Download
M runtime/bin/vmservice/observatory/deployed/web/index_devtools.html_bootstrap.dart.js View 1 2 3 4 396 chunks +8845 lines, -9064 lines 0 comments Download
M runtime/bin/vmservice/observatory/deployed/web/packages/observatory/src/elements/field_ref.html View 1 2 3 4 1 chunk +3 lines, -3 lines 0 comments Download
M runtime/bin/vmservice/observatory/deployed/web/packages/observatory/src/elements/field_view.html View 1 2 3 4 4 chunks +13 lines, -13 lines 0 comments Download
M runtime/bin/vmservice/observatory/lib/src/elements/field_ref.html View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
M runtime/bin/vmservice/observatory/lib/src/elements/field_view.html View 4 chunks +13 lines, -13 lines 0 comments Download
M runtime/bin/vmservice/observatory/lib/src/service/object.dart View 3 chunks +9 lines, -9 lines 0 comments Download
M runtime/vm/object.cc View 1 2 3 4 11 chunks +28 lines, -28 lines 0 comments Download
M runtime/vm/service/protocol.md View 1 2 3 4 7 chunks +12 lines, -12 lines 0 comments Download
M runtime/vm/service_test.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/vmservice/isolate_class_field_test.dart View 1 2 3 4 5 chunks +20 lines, -20 lines 0 comments Download
M tests/standalone/vmservice/isolate_function_test.dart View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
turnidge
turnidge@google.com changed reviewers: + johnmccutchan@google.com
6 years, 3 months ago (2014-08-26 18:08:46 UTC) #1
turnidge
6 years, 3 months ago (2014-08-26 18:08:46 UTC) #2
Cutch
lgtm
6 years, 3 months ago (2014-08-26 20:31:34 UTC) #3
turnidge
6 years, 3 months ago (2014-08-27 17:13:46 UTC) #4
Message was sent while issue was closed.
Committed patchset #5 (id:80001) manually as 39609 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698