Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(760)

Unified Diff: runtime/bin/vmservice/observatory/lib/src/elements/field_view.html

Issue 488233003: More service api cleanup. camelCasePropertyNames (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: gen js, etc. Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/bin/vmservice/observatory/lib/src/elements/field_view.html
diff --git a/runtime/bin/vmservice/observatory/lib/src/elements/field_view.html b/runtime/bin/vmservice/observatory/lib/src/elements/field_view.html
index 307cb7734907ddec9142f7f45c61d46496fdf6c0..c785aaadea13fecf5bb08813d870a055006348bc 100644
--- a/runtime/bin/vmservice/observatory/lib/src/elements/field_view.html
+++ b/runtime/bin/vmservice/observatory/lib/src/elements/field_view.html
@@ -19,7 +19,7 @@
<template if="{{ field['owner'].serviceType == 'Library' }}">
<library-nav-menu library="{{ field['owner'] }}"></library-nav-menu>
</template>
- <nav-menu link="{{ field.link }}" anchor="{{ field['user_name'] }}" last="{{ true }}"></nav-menu>
+ <nav-menu link="{{ field.link }}" anchor="{{ field.name }}" last="{{ true }}"></nav-menu>
<nav-refresh callback="{{ refresh }}"></nav-refresh>
<nav-control></nav-control>
</nav-bar>
@@ -29,14 +29,14 @@
<template if="{{ field['static'] }}">static</template>
<template if="{{ field['final'] }}">final</template>
<template if="{{ field['const'] }}">const</template>
- <template if="{{ (field['declared_type']['name'] == 'dynamic' &&
+ <template if="{{ (field['declaredType'].name == 'dynamic' &&
!field['final'] && !field['const']) }}">
var
</template>
- <template if="{{ (field['declared_type']['user_name'] != 'dynamic') }}">
- {{ field['declared_type']['user_name'] }}
+ <template if="{{ (field['declaredType'].name != 'dynamic') }}">
+ {{ field['declaredType'].name }}
</template>
- {{ field['user_name'] }}
+ {{ field.name }}
</h1>
<div class="memberList">
<div class="memberItem">
@@ -61,19 +61,19 @@
title="The types observed for this field at runtime. Fields that are observed to have a single type at runtime or to never be null may allow for additional optimization.">
<div class="memberName">observed types</div>
<div class="memberValue">
- <template if="{{ field['guard_class'] == 'dynamic' }}">
+ <template if="{{ field['guardClass'] == 'dynamic' }}">
various
</template>
- <template if="{{ field['guard_class'] == 'unknown' }}">
+ <template if="{{ field['guardClass'] == 'unknown' }}">
none
</template>
- <template if="{{ field['guard_class'] != 'unknown' &&
- field['guard_class'] != 'dynamic' }}">
- <class-ref ref="{{ field['guard_class'] }}"></class-ref>
- <template if="{{ field['guard_nullable'] }}">
+ <template if="{{ field['guardClass'] != 'unknown' &&
+ field['guardClass'] != 'dynamic' }}">
+ <class-ref ref="{{ field['guardClass'] }}"></class-ref>
+ <template if="{{ field['guardNullable'] }}">
&mdash; null observed
</template>
- <template if="{{ !field['guard_nullable'] }}">
+ <template if="{{ !field['guardNullable'] }}">
&mdash; null not observed
</template>
</template>
@@ -93,4 +93,4 @@
</template>
</polymer-element>
-<script type="application/dart" src="field_view.dart"></script>
+<script type="application/dart" src="field_view.dart"></script>

Powered by Google App Engine
This is Rietveld 408576698