html escape log messages

html escape log messages

BUG= http://dartbug.com/20539
R=kevmoo@google.com, sigmund@google.com

Committed: https://code.google.com/p/dart/source/detail?r=39408

[Siggi Cherem (dart-lang), 2014-08-19 16:11:50]

lgtm

[kevmoo, 2014-08-19 20:53:03]

comments on const ctor, but otherwise LGTM

https://codereview.chromium.org/487793002/diff/1/pkg/polymer/lib/src/build/wr...
File pkg/polymer/lib/src/build/wrapped_logger.dart (right):

https://codereview.chromium.org/487793002/diff/1/pkg/polymer/lib/src/build/wr...
pkg/polymer/lib/src/build/wrapped_logger.dart:90: 'message': new
HtmlEscape().convert(message),
use the const ctor for HtmlEscape so we're not constantly creating instances

https://codereview.chromium.org/487793002/diff/1/pkg/polymer/test/build/impor...
File pkg/polymer/test/build/import_inliner_test.dart (right):

https://codereview.chromium.org/487793002/diff/1/pkg/polymer/test/build/impor...
pkg/polymer/test/build/import_inliner_test.dart:685: '"message":"${new
HtmlEscape().convert(
use the const ctor for HtmlEscape so we're not constantly creating instances

https://codereview.chromium.org/487793002/diff/1/pkg/polymer/test/build/linte...
File pkg/polymer/test/build/linter_test.dart (right):

https://codereview.chromium.org/487793002/diff/1/pkg/polymer/test/build/linte...
pkg/polymer/test/build/linter_test.dart:667: '"message":${JSON.encode(new
HtmlEscape().convert(
use the const ctor for HtmlEscape so we're not constantly creating instances

[jakemac, 2014-08-20 14:48:19]

https://codereview.chromium.org/487793002/diff/1/pkg/polymer/lib/src/build/wr...
File pkg/polymer/lib/src/build/wrapped_logger.dart (right):

https://codereview.chromium.org/487793002/diff/1/pkg/polymer/lib/src/build/wr...
pkg/polymer/lib/src/build/wrapped_logger.dart:90: 'message': new
HtmlEscape().convert(message),
On 2014/08/19 20:53:02, kevmoo wrote:
> use the const ctor for HtmlEscape so we're not constantly creating instances

Done.

https://codereview.chromium.org/487793002/diff/1/pkg/polymer/test/build/impor...
File pkg/polymer/test/build/import_inliner_test.dart (right):

https://codereview.chromium.org/487793002/diff/1/pkg/polymer/test/build/impor...
pkg/polymer/test/build/import_inliner_test.dart:685: '"message":"${new
HtmlEscape().convert(
On 2014/08/19 20:53:02, kevmoo wrote:
> use the const ctor for HtmlEscape so we're not constantly creating instances

Done.

https://codereview.chromium.org/487793002/diff/1/pkg/polymer/test/build/linte...
File pkg/polymer/test/build/linter_test.dart (right):

https://codereview.chromium.org/487793002/diff/1/pkg/polymer/test/build/linte...
pkg/polymer/test/build/linter_test.dart:667: '"message":${JSON.encode(new
HtmlEscape().convert(
On 2014/08/19 20:53:02, kevmoo wrote:
> use the const ctor for HtmlEscape so we're not constantly creating instances

Done.

[jakemac, 2014-08-20 14:49:07]

Committed patchset #2 manually as 39408 (presubmit successful).