Chromium Code Reviews Chromium Code Reviews
Issue 487793002:
html escape log messages (Closed)
Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart| OLD | NEW |
|---|---|
| 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file | 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file |
| 2 // for details. All rights reserved. Use of this source code is governed by a | 2 // for details. All rights reserved. Use of this source code is governed by a |
| 3 // BSD-style license that can be found in the LICENSE file. | 3 // BSD-style license that can be found in the LICENSE file. |
| 4 | 4 |
| 5 library polymer.test.build.import_inliner_test; | 5 library polymer.test.build.import_inliner_test; |
| 6 | 6 |
| 7 import 'dart:convert'; | 7 import 'dart:convert'; |
| 8 import 'package:polymer/src/build/common.dart'; | 8 import 'package:polymer/src/build/common.dart'; |
| 9 import 'package:polymer/src/build/import_inliner.dart'; | 9 import 'package:polymer/src/build/import_inliner.dart'; |
| 10 import 'package:unittest/compact_vm_config.dart'; | 10 import 'package:unittest/compact_vm_config.dart'; |
| (...skipping 664 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 675 (options) => new ImportInliner(options), | 675 (options) => new ImportInliner(options), |
| 676 "missing html imports throw errors", { | 676 "missing html imports throw errors", { |
| 677 'a|web/test.html': | 677 'a|web/test.html': |
| 678 '<!DOCTYPE html><html><head>' | 678 '<!DOCTYPE html><html><head>' |
| 679 '<link rel="import" href="foo.html">' | 679 '<link rel="import" href="foo.html">' |
| 680 '</head></html>', | 680 '</head></html>', |
| 681 }, { | 681 }, { |
| 682 'a|web/test.html._buildLogs.1': | 682 'a|web/test.html._buildLogs.1': |
| 683 '[{' | 683 '[{' |
| 684 '"level":"Error",' | 684 '"level":"Error",' |
| 685 '"message":"Failed to inline html import: ' | 685 '"message":"${new HtmlEscape().convert( |
|
kevmoo
2014/08/19 20:53:02
use the const ctor for HtmlEscape so we're not con
jakemac
2014/08/20 14:48:18
Done.
| |
| 686 'Could not find asset a|web/foo.html.",' | 686 'Failed to inline html import: ' |
| 687 'Could not find asset a|web/foo.html.')}",' | |
| 687 '"assetId":{"package":"a","path":"web/foo.html"},' | 688 '"assetId":{"package":"a","path":"web/foo.html"},' |
| 688 '"span":{' | 689 '"span":{' |
| 689 '"location":"web/test.html:1:28",' | 690 '"location":"web/test.html:1:28",' |
| 690 '"text":"${new HtmlEscape().convert( | 691 '"text":"${new HtmlEscape().convert( |
| 691 '<link rel="import" href="foo.html">')}"' | 692 '<link rel="import" href="foo.html">')}"' |
| 692 '}' | 693 '}' |
| 693 '}]', | 694 '}]', |
| 694 }, [ | 695 }, [ |
| 695 'error: Failed to inline html import: ' | 696 'error: Failed to inline html import: ' |
| 696 'Could not find asset a|web/foo.html. (web/test.html 0 27)', | 697 'Could not find asset a|web/foo.html. (web/test.html 0 27)', |
| (...skipping 399 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 1096 'a|lib/foo/foo.html': | 1097 'a|lib/foo/foo.html': |
| 1097 '<script rel="import" href="../../../packages/b/bar/bar.js"></script>', | 1098 '<script rel="import" href="../../../packages/b/bar/bar.js"></script>', |
| 1098 'b|lib/bar/bar.js': | 1099 'b|lib/bar/bar.js': |
| 1099 'console.log("here");', | 1100 'console.log("here");', |
| 1100 }, { | 1101 }, { |
| 1101 'a|web/test/well/test.html': | 1102 'a|web/test/well/test.html': |
| 1102 '<!DOCTYPE html><html><head></head><body>' | 1103 '<!DOCTYPE html><html><head></head><body>' |
| 1103 '<script rel="import" href="../../packages/b/bar/bar.js"></script>' | 1104 '<script rel="import" href="../../packages/b/bar/bar.js"></script>' |
| 1104 '</body></html>', | 1105 '</body></html>', |
| 1105 }); | 1106 }); |
| 1106 } | 1107 } |
| OLD | NEW |
