Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issue 48763003: Run the analyzer on dart files under sdk/ -- even in sdk/_internal, if not ending with _test.dart (Closed)

Created:
7 years, 1 month ago by kustermann
Modified:
7 years, 1 month ago
Reviewers:
ricow1
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Run the analyzer on dart files under sdk/ -- even in sdk/_internal, if not ending with _test.dart R=ricow@google.com Committed: https://code.google.com/p/dart/source/detail?r=29420

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -1 line) Patch
M dart/tests/lib/analyzer/analyze_library.status View 1 2 chunks +59 lines, -0 lines 0 comments Download
M dart/tools/testing/dart/test_suite.dart View 1 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
kustermann
7 years, 1 month ago (2013-10-28 15:35:26 UTC) #1
ricow1
LGTM
7 years, 1 month ago (2013-10-28 16:05:52 UTC) #2
kustermann
Small update, excluding "_internal/lib" (which contains patch files ...).
7 years, 1 month ago (2013-10-29 09:01:54 UTC) #3
kustermann
7 years, 1 month ago (2013-10-29 09:02:22 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r29420 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698