dart/tools/testing/dart/test_suite.dart - Issue 48763003: Run the analyzer on dart files under sdk/ -- even in sdk/_internal, if not ending with _test.dart

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: dart/tools/testing/dart/test_suite.dart

Issue 48763003: Run the analyzer on dart files under sdk/ -- even in sdk/_internal, if not ending with _test.dart (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: dart/tools/testing/dart/test_suite.dart

diff --git a/dart/tools/testing/dart/test_suite.dart b/dart/tools/testing/dart/test_suite.dart

index 1ccd0e4670be21c26e2e585daf700ba9aa784a8f..298317bdb0e00d4bdd0bd77d5c8b1ad4362af4e4 100644

--- a/dart/tools/testing/dart/test_suite.dart

+++ b/dart/tools/testing/dart/test_suite.dart

@@ -1617,7 +1617,10 @@ class AnalyzeLibraryTestSuite extends DartcCompilationTestSuite {

bool isTestFile(String filename) {

var sep = Platform.pathSeparator;

- return filename.endsWith(".dart") && !filename.contains("_internal");

+ // NOTE: We exclude tests and patch files for now.

+ return filename.endsWith(".dart") &&

+ !filename.endsWith("_test.dart") &&

+ !filename.contains("_internal/lib");

}

AnalysisCommand makeAnalysisCommand(TestInformation info,

« no previous file with comments | « dart/tests/lib/analyzer/analyze_library.status ('k') | no next file » | no next file with comments »