Issue 486213004: Allow package names to start with underscore.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 486213004: Allow package names to start with underscore. (Closed)

Created:
6 years, 4 months ago by Bob Nystrom

Modified:
6 years, 4 months ago

Reviewers:
nweiz

CC:
reviews_dartlang.org, Søren Gjesse, kustermann

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Allow package names to start with underscore. BUG=https://code.google.com/p/dart/issues/detail?id=20581 R=nweiz@google.com Committed: https://code.google.com/p/dart/source/detail?r=39529

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -2 lines)			Patch
	M	sdk/lib/_internal/pub/lib/src/validator/name.dart	View		1 chunk	+2 lines, -2 lines	0 comments	Download
	M	sdk/lib/_internal/pub/test/validator/name_test.dart	View		1 chunk	+10 lines, -0 lines	0 comments	Download

Total messages: 5 (0 generated)

Bob Nystrom

rnystrom@google.com changed reviewers: + kustermann@google.com, nweiz@google.com, sgjesse@google.com

6 years, 4 months ago (2014-08-25 17:51:58 UTC) #1

Bob Nystrom

rnystrom@google.com changed reviewers: - kustermann@google.com, sgjesse@google.com

6 years, 4 months ago (2014-08-25 17:52:15 UTC) #3

Bob Nystrom

6 years, 4 months ago (2014-08-25 20:07:24 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 manually as 39529 (presubmit successful).