Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(656)

Unified Diff: sdk/lib/_internal/pub/test/validator/name_test.dart

Issue 486213004: Allow package names to start with underscore. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sdk/lib/_internal/pub/lib/src/validator/name.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/_internal/pub/test/validator/name_test.dart
diff --git a/sdk/lib/_internal/pub/test/validator/name_test.dart b/sdk/lib/_internal/pub/test/validator/name_test.dart
index 6a70d11ff8b79433ba77040b1d7fedd8a1ce85c9..17a460fe02e3a5bef7f3ef78d26ee2e8749bfae7 100644
--- a/sdk/lib/_internal/pub/test/validator/name_test.dart
+++ b/sdk/lib/_internal/pub/test/validator/name_test.dart
@@ -33,6 +33,16 @@ main() {
]).create();
expectNoValidationError(name);
});
+
+ integration('has a name that starts with an underscore', () {
+ d.dir(appPath, [
+ d.libPubspec("_test_pkg", "1.0.0"),
+ d.dir("lib", [
+ d.file("_test_pkg.dart", "int i = 1;")
+ ])
+ ]).create();
+ expectNoValidationError(name);
+ });
});
group('should consider a package invalid if it', () {
« no previous file with comments | « sdk/lib/_internal/pub/lib/src/validator/name.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698